Skip to content

Edit pass on Monitor Query README file #19979

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
rakshith91 merged 2 commits into from
Jul 29, 2021
Merged

Edit pass on Monitor Query README file #19979

rakshith91 merged 2 commits into from
Jul 29, 2021

Conversation

@scottaddie
Copy link
Member

@scottaddie scottaddie commented Jul 28, 2021

Summary of changes

  • Incorporate Acrolinx feedback
  • Fix formatting in code samples
  • Show how to use async query clients
  • Update Azure subscription link to Python-specific link
  • Trim the amount of detail in "Key concepts" section and link to docs where possible
  • Provide a link to each example in the "Examples" section
  • Relocate the logs query timeout section

@scottaddie scottaddie requested a review from rakshith91 as a code owner July 28, 2021 17:11
rakshith91
rakshith91 approved these changes Jul 29, 2021
View reviewed changes
Copy link
Contributor

@rakshith91 rakshith91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great stuff - lgtm

@rakshith91 rakshith91 merged commit fa95a09 into main Jul 29, 2021
@rakshith91 rakshith91 deleted the scottaddie/monitor-query-readme branch July 29, 2021 21:00
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Aug 2, 2021
@iscai-msft
Merge branch 'main' of https://github.com/Azure/azure-sdk-for-python …
d4c38a7 
…into add_chardet_dep

* 'main' of https://github.com/Azure/azure-sdk-for-python: (35 commits)
  `azure-applicationinsights` Hyperlinks need sphinx style formatting (Azure#19993)
  update version and changelog (Azure#20034)
  Rename AZURE_POD_IDENTITY_TOKEN_URL -> AZURE_POD_IDENTITY_AUTHORITY_HOST (Azure#19867)
  add sample for raw_response_hook (Azure#19985)
  cut hard dependency on requests (Azure#19930)
  Update ci.yml (Azure#20028)
  Update ci.yml (Azure#20026)
  Update PythonSdkLiveTest.yml (Azure#19999)
  [AutoRelease] t2-recoveryservicessiterecovery-2021-07-28-40357 (Azure#19970)
  [AutoRelease] t2-storagecache-2021-07-29-63871 (Azure#19987)
  Minor changes in docs (Azure#20016)
  Add Logs Batch query results (Azure#20013)
  Rename query (Azure#19952)
  d218371 (Azure#20009)
  Update CHANGELOG.md (Azure#20006)
  [Batch] Data plane SDK v11.0.0 (Azure#19889)
  [AutoRelease] t2-batch-2021-07-30-27488 (Azure#19996)
  add ga id to index (Azure#19995)
  Edit pass on Monitor Query README file (Azure#19979)
  Move stress testing scripts to eng/common (Azure#19994)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@rakshith91 rakshith91 rakshith91 approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@scottaddie @rakshith91