deprecate loop parameter #19927
Merged
deprecate loop parameter #19927
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Member
Author
annatisch
approved these changes
Jul 23, 2021
| """ | ||
| def __init__(self, *, session: Optional[aiohttp.ClientSession] = None, loop=None, session_owner=True, **kwargs): | ||
| if loop and sys.version_info >= (3, 10): | ||
| raise ValueError("Starting Python 3.10, asyncio doesn’t support loop as a parameter anymore") |
Member
There was a problem hiding this comment.
Do we want to add a deprecation warning if loop and sys.version_info < (3, 10)?
Member
There was a problem hiding this comment.
Grammar nitpick: Starting with Python 3.10, asyncio no longer supports the loop parameter.
Member
Author
There was a problem hiding this comment.
No. If user does not use Python >= 3.10, we want to behave exactly same. There should be no impact at all. (new warnings are still side effects.)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.