Refactor SharedTokenCacheCredential #19914
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
mccoyp
approved these changes
Jul 27, 2021
Member
mccoyp
left a comment
mccoyp
left a comment
There was a problem hiding this comment.
Super nice change, thank you for noticing the opportunity to split these up!
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
SharedTokenCacheCredential takes one of two distinct code paths depending on whether it's initialized with an AuthenticationRecord. It's basically two credential types mashed together (my bad). That makes it difficult to understand and maintain, so here I am unmashing that which has been mashed. I think this will be a boon for future generations, and today it makes fixing #19746 easier 😊