Introduce 'top' filter to Pricesheet API#1977
Introduce 'top' filter to Pricesheet API#1977lmazuel merged 3 commits intoAzure:restapi_auto_consumption/resource-managerfrom
Conversation
# Conflicts: # azure-mgmt-consumption/tests/test_mgmt_consumption.py
…est. All files besides the following are related to line-endings. Since AutoRest generated the files, its left as is. price_sheet_operations.py test_mgmt_consumption.test_consumption_subscription_price_sheet.yaml consumption/version.py was reset to 2.0.0 (different than what AutoRest generated)
Codecov Report
@@ Coverage Diff @@
## master #1977 +/- ##
==========================================
+ Coverage 53.17% 53.17% +<.01%
==========================================
Files 4714 4714
Lines 117148 117152 +4
==========================================
+ Hits 62295 62298 +3
- Misses 54853 54854 +1
Continue to review full report at Codecov.
|
|
@lmazuel - Yes, the swagger for Pricesheet API was updated\published\merged prior to this PR, and it does support top. The changes you notice in this PR are auto-generated using AutoRest based on the Azure Rest api repository. Also, you'll notice in the new recording, the request and response for pricesheet respects the top setting. Link: https://github.com/Azure/azure-rest-api-specs/blob/master/specification/consumption/resource-manager/Microsoft.Consumption/stable/2018-01-31/consumption.json refer to ln 1010. Thank you. |
|
@lmazuel I do see $top swagger changes here Azure/azure-rest-api-specs#2485. As swagger is already updated I think we are good for merge, LMK if any suggestions. |
|
@shbha @kjeur seems you didn't expose on your github profile your organisations (so you don't have the "Member" tag on your contribution), so I didn't realize this was a contribution from Microsoft and not a random customer :). We have regular contributions from customers that doesn't know we use Swagger, and since you didn't describe the change @shbha , I didn't know there was a Swagger. |
lmazuel
changed the base branch from
master
to
restapi_auto_consumption/resource-manager
|
Merged to feature branch |
…le values in examples. Earlier version had incorrect format for the date values. (#1999) * Introduce 'top' filter to Pricesheet API (#1977) * Introducing (rough) tests around Price Sheet API. * Introduce 'top' filter to Pricesheet Api. And update the associated test. All files besides the following are related to line-endings. Since AutoRest generated the files, its left as is. price_sheet_operations.py test_mgmt_consumption.test_consumption_subscription_price_sheet.yaml consumption/version.py was reset to 2.0.0 (different than what AutoRest generated) * Generated from cbefdc6e1ebb76efd65b14d3737cc6fe6f20d0d0 Updating $filter parameter sample values in examples. Earlier version had incorrect format for the date values. * Update version.py
5 participants
No description provided.