Skip to content

Conversation

@kristapratico
Copy link
Contributor

Feedback to drop "Type" from the enums. Other languages don't seem to have the Type suffix from what I can see.

  • Removed HealthcareEntityRelationRoleType
  • Renamed HealthcareEntityRelationType to HealthcareEntityRelation
  • Renamed PiiEntityCategoryType to PiiEntityCategory
  • Renamed PiiEntityDomainType to PiiEntityDomain
  • Fixed type hints and docstrings for begin_analyze_healthcare_entities and begin_analyze_actions to include DocumentError in the heterogeneous output

Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thank you @kristapratico !!!

@iscai-msft iscai-msft merged commit 8cb17c0 into Azure:main Jun 25, 2021
iscai-msft added a commit that referenced this pull request Jun 25, 2021
…into rest_layer

* 'main' of https://github.com/Azure/azure-sdk-for-python:
  [core] add testserver (#19153)
  autorest repo needs to checkout from master still (#19499)
  [Event Hubs] [Service Bus] add logging snippet to readme (#19171)
  apiview / anna feedback (#19473)
  Make IMDS unavailability easier to debug (#19423)
  [Resourcehealth] first release (#19484)
  CAE support for azure-mgmt-core (#19365)
  Update references from master to main (#19471)
  Update links from master to main
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants