[Blob][Fileshare] Ensured that download fails if blob/file modified mid download #19276
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tasherif-msft
requested review from
amishra-dev,
annatisch,
kasobol-msft,
xiafu-msft and
zezha-msft
as code owners
ghost
added
the
tasherif-msft
changed the title
kasobol-msft
approved these changes
Jun 16, 2021
| **self.request_options | ||
| ) | ||
| if response.properties.etag != self.etag: | ||
| raise ValueError("The file has been modified while downloading.") |
Contributor
There was a problem hiding this comment.
Please check with @annatisch if this is right exception type.
Contributor
There was a problem hiding this comment.
In dotnet we throw this and provide more data than just message.
Contributor
Author
There was a problem hiding this comment.
Confirmed with @xiafu-msft and we are now throwing ResourceModifiedError as per blob natively does in this case.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Blobs:
Currently in blobs we lock on etag, and we try to let the user override this by passing
If-Match:'*'but the logic was incorrect which just led to the ability to modify a blob during the second chunked call, otherwise it would still fail. I have removed this extra logic completely.Fileshare:
Added locking on etag - previously there was no etag locking.