Conversation
Mark vault creation as a long running operation
|
@lmazuel I really like this flow. It definitely will reduce some of the noise and confusion when you have multiple changes and several pending PRs at the same time. As to using this branch for our azure-mgmt-keyvault preview, I will probably merge these changes into our keyvault_1.0_preview branch and publish previews for both our packages from this branch. This is easier as it allows me to have both preview packages installed through dev_setup and they can both be tested together. Thoughts? |
|
@schaabs LGTM. I think we should close this PR and delete the branch when you will release a new ARM package from your preview branch (or from master). A new PR with a fresh branch will be re-created anyway the next time you touch the ARM Swaggers files, and this ensure the branch is still in sync. |
adding storage permissions for soft delete and backup restore
|
Closing this pull request. Will update fix the tests in this branch then open a pull request from this branch into keyvault_1.0_preview |
3 participants
@schaabs The new automation system now groups automatically by context. This means each time a Swagger change to ARM KV is made, this goes here, and not to yet another PR. This should simplify your review system. You can even take this branch as your ARM preview if you like.
Thoughts?