[FarmBeats, Test] Hardcoded endpoint for statically set up resource #19198
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
Author
|
@benbp cc |
benbp
approved these changes
Jun 10, 2021
benbp
reviewed
Jun 10, 2021
| "AGRIFOOD_ENDPOINT": { | ||
| "type": "string", | ||
| "value": "[reference(resourceId('Microsoft.AgFoodPlatform/farmbeats', variables('resourceName'))).instanceUri]" | ||
| "value": "https://internal-sdk-live-test-py.farmbeats.azure.net" |
Member
There was a problem hiding this comment.
Does the test identity have access to this resource?
Contributor
Author
There was a problem hiding this comment.
Yep, gave it access.
Contributor
Author
|
@lmazuel We are also ready to merge this |
Contributor
Author
|
/azp run python - agrifood - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run python - agrifood - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run python - agrifood - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run python - agrifood - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
to test with the additional configs in test.yml This reverts commit 0f4e319.
Contributor
Author
|
/azp run python - agrifood - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
due to low time resolution on server
Contributor
Author
|
/azp run python - agrifood - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run python - agrifood - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run python - agrifood - test |
|
No pipelines are associated with this pull request. |
Contributor
Author
|
/azp run python - agrifood - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Contributor
Author
|
/azp run python - agrifood - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
iscai-msft
approved these changes
Jun 22, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Set up resource and assigned the right role to the test principal.
Removed the deployment of farmbeats instance and the role assignment from the template, and hardcoded the endpoint for the resource above into the outputs from the template.