[AutoPR authorization/resource-manager] All updates by lmazuel · Pull Request #1916 · Azure/azure-sdk-for-python

lmazuel · 2018-02-06T18:17:06Z

@yugangw-msft Ready to install as 0.40.0

lmazuel · 2018-02-21T19:19:11Z

Tests KO since 2018-01-01-preview is not out yet.

lmazuel · 2018-02-28T18:18:07Z

Authorization py 0.40.0

Fix parameter location

…sion for classicadmin in powershell (#1993) * Generated from 80afa52b390ebc93e528ab47d32fe4f95bae49cf fix the hardcoding of api version for classicadmin in sdk * Generated from 228c368e8b1956804f353314932a9a506630e8dd fix 2017 version preview file

AutorestCI · 2018-02-28T18:23:33Z

Rebase done and pushed to the branch

lmazuel · 2018-02-28T22:46:42Z

@AutorestCI rebuild https://github.com/Azure/azure-rest-api-specs/blob/master/specification/authorization/resource-manager/readme.md

AutorestCI · 2018-02-28T22:47:25Z

Nothing to rebuild, this PR is up to date

darshanhs90 · 2018-02-28T22:54:51Z

you might need to rerecord the tests,since this was recorded before the new api version was rolled out

Refers to: azure-mgmt-authorization/tests/recordings/test_mgmt_authorization.test_authorization.yaml:29 in 62edb5d. [](commit_id = 62edb5d, deletion_comment = False)

darshanhs90 · 2018-02-28T22:55:19Z

The api version is out now.

In reply to: 367439171 [](ancestors = 367439171)

lmazuel · 2018-02-28T23:21:32Z

@yugangw-msft for review as well

… to be in sync with the filters present in service (#2094) * Generated from f8898998fb594903a540b2013f9bd29e852e0487 Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs * Generated from f8898998fb594903a540b2013f9bd29e852e0487 Merge branch 'master' of https://github.com/Azure/azure-rest-api-specs

AutorestCI · 2018-03-07T21:16:19Z

(message created by the CI based on PR content)

Installation instruction

Package azure-mgmt-authorization

You can install the package azure-mgmt-authorization of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_authorization/resource-manager#egg=azure-mgmt-authorization&subdirectory=azure-mgmt-authorization"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_authorization/resource-manager#egg=azure-mgmt-authorization&subdirectory=azure-mgmt-authorization"

If you have a local clone of this repository, you can also do:

git checkout restapi_auto_authorization/resource-manager
pip install -e ./azure-mgmt-authorization

Or build a wheel file to distribute for testing:

git checkout restapi_auto_authorization/resource-manager
pip wheel --no-deps ./azure-mgmt-authorization

Package azure-mgmt

You can install the package azure-mgmt of this PR using the following command:
pip install "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_authorization/resource-manager#egg=azure-mgmt&subdirectory=azure-mgmt"

You can build a wheel to distribute for test using the following command:
pip wheel --no-deps "git+https://github.com/Azure/azure-sdk-for-python@restapi_auto_authorization/resource-manager#egg=azure-mgmt&subdirectory=azure-mgmt"

If you have a local clone of this repository, you can also do:

git checkout restapi_auto_authorization/resource-manager
pip install -e ./azure-mgmt

Or build a wheel file to distribute for testing:

git checkout restapi_auto_authorization/resource-manager
pip wheel --no-deps ./azure-mgmt

Direct download

Your files can be directly downloaded here:

codecov-io · 2018-03-09T01:22:34Z

Codecov Report

Merging #1916 into master will decrease coverage by 1.1%.
The diff coverage is 45.03%.

@@            Coverage Diff             @@
##           master    #1916      +/-   ##
==========================================
- Coverage   53.06%   51.95%   -1.11%     
==========================================
  Files        4774     5141     +367     
  Lines      119483   132364   +12881     
==========================================
+ Hits        63406    68776    +5370     
- Misses      56077    63588    +7511

Impacted Files	Coverage Δ
...t/authorization/authorization_management_client.py	`100% <100%> (ø)`	⬆️
...zation/azure/mgmt/authorization/models/__init__.py	`100% <100%> (ø)`	⬆️
...-authorization/azure/mgmt/authorization/version.py	`100% <100%> (ø)`	⬆️
...on/azure/mgmt/authorization/operations/__init__.py	`100% <100%> (ø)`	⬆️
...tion/azure/mgmt/authorization/models/permission.py	`100% <100%> (ø)`	⬆️
.../azure/mgmt/authorization/models/permission_py3.py	`100% <100%> (ø)`
...thorization/models/provider_operations_metadata.py	`36.36% <12.5%> (-3.64%)`	⬇️
...re/mgmt/authorization/models/provider_operation.py	`36.36% <12.5%> (-8.09%)`	⬇️
...mgmt/authorization/models/classic_administrator.py	`40% <14.28%> (-10%)`	⬇️
...azure/mgmt/authorization/models/role_definition.py	`35.71% <18.18%> (-14.29%)`	⬇️
... and 573 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f746c62...7e57cf5. Read the comment docs.

yugangw-msft · 2018-03-12T20:15:38Z

@lmazuel , I have verified, could you please publish it?

lmazuel · 2018-03-13T21:08:53Z

azure-mgmt-authorization/azure/mgmt/authorization/models/classic_administrator.py

        'name': {'key': 'name', 'type': 'str'},
        'type': {'key': 'type', 'type': 'str'},
-        'properties': {'key': 'properties', 'type': 'ClassicAdministratorProperties'},
+        'email_address': {'key': 'properties.emailAddress', 'type': 'str'},


breaking:
properties.email_address => email_address
properties.role => role

lmazuel · 2018-03-13T21:09:30Z

azure-mgmt-authorization/azure/mgmt/authorization/models/permission.py

+        super(Permission, self).__init__(**kwargs)
+        self.actions = kwargs.get('actions', None)
+        self.not_actions = kwargs.get('not_actions', None)
+        self.data_actions = kwargs.get('data_actions', None)


new data_actions / not_data_actions

lmazuel · 2018-03-13T21:09:44Z

azure-mgmt-authorization/azure/mgmt/authorization/models/provider_operation.py

    :type origin: str
    :param properties: The operation properties.
    :type properties: object
+    :param is_data_action: The dataAction flag to specify the operation type.


new is_data_action

lmazuel · 2018-03-13T21:10:37Z

azure-mgmt-authorization/azure/mgmt/authorization/models/role_assignment.py

        'name': {'key': 'name', 'type': 'str'},
        'type': {'key': 'type', 'type': 'str'},
-        'properties': {'key': 'properties', 'type': 'RoleAssignmentPropertiesWithScope'},
+        'scope': {'key': 'properties.scope', 'type': 'str'},


lmazuel · 2018-03-13T21:10:45Z

azure-mgmt-authorization/azure/mgmt/authorization/models/role_assignment_create_parameters.py


    _attribute_map = {
-        'properties': {'key': 'properties', 'type': 'RoleAssignmentProperties'},
+        'role_definition_id': {'key': 'properties.roleDefinitionId', 'type': 'str'},


lmazuel · 2018-03-13T21:11:20Z

azure-mgmt-authorization/azure/mgmt/authorization/operations/permissions_operations.py

-    :param deserializer: An objec model deserializer.
-    :ivar api_version: The API version to use for this operation. Constant value: "2015-07-01".
+    :param deserializer: An object model deserializer.
+    :ivar api_version: The API version to use for this operation. Constant value: "2018-01-01-preview".


new api version

lmazuel · 2018-03-13T21:11:54Z

azure-mgmt-authorization/azure/mgmt/authorization/operations/role_assignments_operations.py


    def create_by_id(
-            self, role_assignment_id, properties=None, custom_headers=None, raw=False, **operation_config):
+            self, role_id, parameters, custom_headers=None, raw=False, **operation_config):


lmazuel requested a review from yugangw-msft February 6, 2018 18:17

lmazuel assigned yugangw-msft Feb 6, 2018

lmazuel mentioned this pull request Feb 6, 2018

[Authorization] New API version #1645

Closed

lmazuel added the ServicePR label Feb 7, 2018

AutorestCI mentioned this pull request Feb 15, 2018

fix the hardcoding of api version for classicadmin in powershell Azure/azure-rest-api-specs#2502

Merged

10 tasks

lmazuel force-pushed the restapi_auto_authorization/resource-manager branch from 9ea1e91 to 2bf12ff Compare February 21, 2018 19:19

lmazuel mentioned this pull request Feb 22, 2018

[AutoPR authorization/resource-manager] Corrected API versions #1967

Closed

AutorestCI and others added 4 commits February 28, 2018 18:23

Generated from 5e122049229875c775c412be46ee2548b94cceef

b03ec7e

Authorization py 0.40.0

Generated from 6a6fa572480fbef059499165c601d7a489bbf1a4

35ac780

Fix parameter location

Migrate tests to new framework

62edb5d

AutorestCI force-pushed the restapi_auto_authorization/resource-manager branch from 2bf12ff to 62edb5d Compare February 28, 2018 18:23

Azure deleted a comment from AutorestCI Feb 28, 2018

AutorestCI added the ServicePR label Mar 2, 2018

AutorestCI mentioned this pull request Mar 2, 2018

update roledefinition filters to be in sync with the filters present in service Azure/azure-rest-api-specs#2586

Merged

10 tasks

New records

91687e5

yugangw-msft approved these changes Mar 12, 2018

View reviewed changes

lmazuel commented Mar 13, 2018

View reviewed changes

azure-mgmt-authorization 0.40.0

7e57cf5

lmazuel merged commit 0409ece into master Mar 13, 2018

lmazuel deleted the restapi_auto_authorization/resource-manager branch March 13, 2018 22:43

Comments

Conversation

lmazuel commented Feb 6, 2018

Uh oh!

lmazuel commented Feb 21, 2018

Uh oh!

lmazuel commented Feb 28, 2018

Uh oh!

AutorestCI commented Feb 28, 2018

Uh oh!

lmazuel commented Feb 28, 2018

Uh oh!

AutorestCI commented Feb 28, 2018

Uh oh!

darshanhs90 commented Feb 28, 2018

Uh oh!

darshanhs90 commented Feb 28, 2018

Uh oh!

lmazuel commented Feb 28, 2018

Uh oh!

AutorestCI commented Mar 7, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Installation instruction

Package azure-mgmt-authorization

Package azure-mgmt

Direct download

Uh oh!

codecov-io commented Mar 9, 2018 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

yugangw-msft commented Mar 12, 2018

Uh oh!

lmazuel Mar 13, 2018

Choose a reason for hiding this comment

Uh oh!

lmazuel Mar 13, 2018

Choose a reason for hiding this comment

Uh oh!

lmazuel Mar 13, 2018

Choose a reason for hiding this comment

Uh oh!

lmazuel Mar 13, 2018

Choose a reason for hiding this comment

Uh oh!

lmazuel Mar 13, 2018

Choose a reason for hiding this comment

Uh oh!

lmazuel Mar 13, 2018

Choose a reason for hiding this comment

Uh oh!

lmazuel Mar 13, 2018

Choose a reason for hiding this comment

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

5 participants

AutorestCI commented Mar 7, 2018 •

edited

Loading

codecov-io commented Mar 9, 2018 •

edited

Loading