add create_synonym_map_from_file #18811
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
|
||
| @classmethod | ||
| def create_from_file(cls, name, file_path): | ||
| f = open(file_path, "r") |
Contributor
There was a problem hiding this comment.
I think it might make sense to open the file in a context manager so the file gets closed
| def create_from_file(cls, name, file_path): | ||
| f = open(file_path, "r") | ||
| solr_format_synonyms = f.read() | ||
| synonyms = solr_format_synonyms.split("\n") |
Contributor
There was a problem hiding this comment.
Is it possible to use splitlines() instead? I think split("\n") will include a trailing newline in the file.
Member
Author
There was a problem hiding this comment.
Yes. If there is a trailing newline in the file, we will have an empty synonym.
This is by design and we have same behavior in https://github.com/Azure/azure-sdk-for-python/blob/master/sdk/search/azure-search-documents/azure/search/documents/indexes/models/_models.py#L460
kristapratico
approved these changes
May 19, 2021
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
May 6, 2022
[App Configuration] Promote 2022-05-01 stable version (Azure#18811) * Add 2022-05-01 folder based on 2021-10-01-preview * Update 2022-05-01 folder * Fix readme issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.