Skip to content

Conversation

@benbp
Copy link
Member

@benbp benbp commented May 6, 2021

These parameters are unused, and it's causing some template validation errors against Azure/azure-sdk-tools#1585, which uses a more strict parameter checking syntax.

{"$id":"1","customProperties":{"ValidationResults":[{"result":"error","message":"/eng/pipelines/templates/stages/archetype-python-release.yml (Line: 182, Col: 42): Unexpected parameter 'TargetDocRepo'"},{"result":"error","message":"/eng/pipelines/templates/stages/archetype-python-release.yml (Line: 188, Col: 45): Unexpected parameter 'ServiceDirectory'"}]},"innerException":null,"message":"Could not queue the build because there were validation errors or warnings.","typeName":"Microsoft.TeamFoundation.Build.WebApi.BuildRequestValidationFailedException, Microsoft.TeamFoundation.Build2.WebApi","typeKey":"BuildRequestValidationFailedException","errorCode":0,"eventId":3000}

@@ -179,13 +179,11 @@ stages:
ReleaseSha: $(Build.SourceVersion)
RepoId: Azure/azure-sdk-for-python
WorkingDirectory: $(System.DefaultWorkingDirectory)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

FYI @danieljurek this is just a small part of the clean-up we need to do for the docs processing once you refactor it for the daily packages as well.

@benbp benbp self-assigned this May 10, 2021
@benbp benbp added the Central-EngSys This issue is owned by the Engineering System team. label May 10, 2021
@benbp benbp merged commit 0c1d1e7 into Azure:master May 10, 2021
@benbp benbp deleted the benbp/unused-vars branch May 10, 2021 18:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Central-EngSys This issue is owned by the Engineering System team.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants