[formrecognizer] update multipage receipt sample for tests#18473
Merged
kristapratico merged 1 commit intoAzure:masterfrom May 3, 2021
Merged
[formrecognizer] update multipage receipt sample for tests#18473kristapratico merged 1 commit intoAzure:masterfrom
kristapratico merged 1 commit intoAzure:masterfrom
Conversation
iscai-msft
approved these changes
May 3, 2021
catalinaperalta
approved these changes
May 3, 2021
Member
catalinaperalta
left a comment
catalinaperalta
left a comment
There was a problem hiding this comment.
LGTM! Just out of curiosity, why did the service team suggest the change?
Contributor
Author
The original sample was created by our team but this was before we knew what a multipage sample for receipts should look like. The old sample reads more like an invoice, whereas the "correct" type of sample should be multiple sales receipt scanned/copied into a PDF. We've seen "regressions" on these tests for almost every new service version because it's not really the right sample for this prebuilt model. So fixing it finally. :) |
azure-sdk
pushed a commit
to azure-sdk/azure-sdk-for-python
that referenced
this pull request
Apr 11, 2022
Dev-datamigration-Microsoft.DataMigration-2022-03-30-preview (Azure#18213) * Initial Commit * Updating the API version of files * Adding New APIs, examples and properties * fixing model validation and spell check error * Adding Identifier to array * Solving pretty check * Adding TableList and Force delete * Correcting table list example * Updating expand description * Updating examples * Adding filestoragetype on swagger and minmi example * Adding tablelist and sqldbthresholds to examples response * Removing SQLDBbackupconfiguration and RowThreshold (Azure#18473) * fixing s360 errors and adding secure strings (Azure#18593) * fixing s360 errors and adding secure strings * nit error * pretty check * fileshare password as secure string * Revert "pretty check" This reverts commit 677d27c00d5a1185a942873bc02fa54c08fcde03. * nit error * Revert "nit error" This reverts commit 345b38af7f3344a85d666b547acd91fd769a66d2. * removing extra space * moving targetDatabaseCollation and provisioningError Co-authored-by: Vasundhra Manhas <vmanhas@microsoft.com> Co-authored-by: Vasundhra Manhas <42461257+vasundhraManhas@users.noreply.github.com> Co-authored-by: Vasundhra Manhas <vmanhas@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #18072
Preparation for targeting/testing the 2.1 GA endpoints - unskips some tests and updates the multipage receipt sample per service team recommendation.