Skip to content

Sync eng/common directory with azure-sdk-tools for PR 1524 #18450

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azure-sdk merged 7 commits into from
May 3, 2021
Merged

Sync eng/common directory with azure-sdk-tools for PR 1524 #18450

Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
b6de910
Make RELEASE_TITLE_REGEX more specific
chidozieononiwu Mar 26, 2021
958f9d2
Update eng/common/scripts/ChangeLog-Operations.ps1
chidozieononiwu Mar 30, 2021
b3d37f8
Update release REGEX
chidozieononiwu Apr 23, 2021
1be326a
tighten up changelog verification
chidozieononiwu Apr 28, 2021
f89a981
Ensure releaseDate is in the appriopriate format.
chidozieononiwu Apr 28, 2021
2885962
Update error messages.
chidozieononiwu Apr 29, 2021
91fb858
Retrun false after error
chidozieononiwu Apr 29, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 13 additions & 3 deletions eng/common/scripts/ChangeLog-Operations.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,7 @@
. "${PSScriptRoot}\logging.ps1"
. "${PSScriptRoot}\SemVer.ps1"

$RELEASE_TITLE_REGEX = "(?<releaseNoteTitle>^\#+.*(?<version>\b\d+\.\d+\.\d+([^0-9\s][^\s:]+)?)(\s+(?<releaseStatus>\(.*\)))?)"
$RELEASE_TITLE_REGEX = "(?<releaseNoteTitle>^\#+\s+(?<version>$([AzureEngSemanticVersion]::SEMVER_REGEX))(\s+(?<releaseStatus>\(.+\))))"
$CHANGELOG_UNRELEASED_STATUS = "(Unreleased)"
$CHANGELOG_DATE_FORMAT = "yyyy-MM-dd"

Expand Down Expand Up @@ -120,7 +120,17 @@ function Confirm-ChangeLogEntry {
else {
$status = $changeLogEntry.ReleaseStatus.Trim().Trim("()")
try {
[DateTime]$status
$releaseDate = [DateTime]$status
if ($status -ne ($releaseDate.ToString($CHANGELOG_DATE_FORMAT)))
{
LogError "Date must be in the format $($CHANGELOG_DATE_FORMAT)"
return $false
}
if (((Get-Date).AddMonths(-1) -gt $releaseDate) -or ($releaseDate -gt (Get-Date).AddMonths(1)))
{
LogError "The date must be within +/- one month from today."
return $false
}
}
catch {
LogError "Invalid date [ $status ] passed as status for Version [$($changeLogEntry.ReleaseVersion)]."
Expand Down Expand Up @@ -212,4 +222,4 @@ function Set-ChangeLogContent {
}

Set-Content -Path $ChangeLogLocation -Value $changeLogContent
}
}