Skip to content

Comments

[Container Registry] Acr enums#18400

Merged
27 commits merged intoAzure:masterfrom
seankane-msft:acr-enums
May 11, 2021
Merged

[Container Registry] Acr enums#18400
27 commits merged intoAzure:masterfrom
seankane-msft:acr-enums

Conversation

@seankane-msft
Copy link
Contributor

Dependent on #18397

@seankane-msft seankane-msft self-assigned this Apr 28, 2021
@seankane-msft seankane-msft marked this pull request as draft April 28, 2021 20:02
@seankane-msft seankane-msft marked this pull request as ready for review May 6, 2021 15:18
@seankane-msft
Copy link
Contributor Author

Dependent on #18392

@seankane-msft seankane-msft added this to the [2021] May milestone May 6, 2021
@seankane-msft seankane-msft requested a review from swathipil May 7, 2021 21:24
@check-enforcer
Copy link

check-enforcer bot commented May 7, 2021

This pull request is protected by Check Enforcer.

What is Check Enforcer?

Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass.

Why am I getting this message?

You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged.

What should I do now?

If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows:
/check-enforcer evaluate
Typically evaulation only takes a few seconds. If you know that your pull request is not covered by a pipeline and this is expected you can override Check Enforcer using the following command:
/check-enforcer override
Note that using the override command triggers alerts so that follow-up investigations can occur (PRs still need to be approved as normal).

What if I am onboarding a new service?

Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment:
/azp run prepare-pipelines
This will run a pipeline that analyzes the source tree and creates the pipelines necessary to build and validate your pull request. Once the pipeline has been created you can trigger the pipeline using the following comment:
/azp run python - [service] - ci

Comment on lines 111 to 114
for data in ArtifactArchitecture:
if data.value == self.architecture:
self.architecture = data
break
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You should be able to do ArtifactArchitecture(self.architecture) if you want to convert the string to the enum type. Is this an input or result model? I feel like python users prefer to work with strings but ignore me if this design decision was already made.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is a result model. The ArtifactArchitecture inherits from str and Enum, users should be able to work with strings with this model.

seankane-msft and others added 3 commits May 11, 2021 08:08
…egistry/_models.py

Co-authored-by: Krista Pratico <krpratic@microsoft.com>
…egistry/_models.py

Co-authored-by: Krista Pratico <krpratic@microsoft.com>
@ghost
Copy link

ghost commented May 11, 2021

Hello @seankane-msft!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 3c826c4 into Azure:master May 11, 2021
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants