Skip to content

Conversation

@jbeauregardb
Copy link
Contributor

No description provided.

@ghost ghost added the Communication label Apr 13, 2021
@jbeauregardb jbeauregardb force-pushed the communication-contributing-file branch 2 times, most recently from ed83e98 to 02760ac Compare April 13, 2021 19:49
@jbeauregardb jbeauregardb force-pushed the communication-contributing-file branch from 02760ac to 9ae040c Compare April 13, 2021 19:50

Once the package has been installed on your machine, let's jump on how to run the tests to see that everything is in order.

## Testing
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We should have a reference to the general doc for live tests here

@jbeauregardb jbeauregardb marked this pull request as ready for review April 20, 2021 15:53
@jbeauregardb jbeauregardb force-pushed the communication-contributing-file branch from cadf018 to e01c977 Compare April 20, 2021 17:47
@jbeauregardb jbeauregardb force-pushed the communication-contributing-file branch from e01c977 to ddb77c0 Compare April 20, 2021 18:55
@jbeauregardb jbeauregardb force-pushed the communication-contributing-file branch from ddb77c0 to 51cfd6e Compare April 20, 2021 18:56
Copy link
Member

@JoshuaLai JoshuaLai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great with the changes!

@jbeauregardb jbeauregardb merged commit 16771a6 into Azure:master Apr 20, 2021
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Apr 22, 2021
…into azure_purview_catalog

* 'master' of https://github.com/Azure/azure-sdk-for-python: (205 commits)
  update FormField docstring (Azure#18226)
  [Event Hubs] combine conn str parsing logic (Azure#18059)
  [Blob]Edit Test for Single Thread Substream Retry (Azure#18206)
  maintenance changelog config (Azure#18216)
  Privated hierarchy traversal and fixed encryption algorithm (Azure#18212)
  Remove duplicate calls to bypass-local-dns.yml (Azure#18180)
  Patch changelog (Azure#18188)
  enable polling by default (Azure#18184)
  [Communication]: Added identity exception tests (Azure#18191)
  version (Azure#18202)
  [AutoRelease] t2-maintenance-2021-04-20-69227 (Azure#18166)
  Updated identity samples (Azure#18189)
  Sync eng/common directory with azure-sdk-tools for PR 1565 (Azure#18155)
  Clean Up PR Triggers (Azure#18186)
  [Tables] on a 413 throw a RequestEntity Too Large Error (Azure#18181)
  Add environment.yml to unify conda versioning (Azure#18141)
  [Fix]Add retry for streaming download (Azure#18164)
  Sync eng/common directory with azure-sdk-tools for PR 1558 (Azure#18178)
  Stop filtering projects by ci.yml files (Azure#18174)
  [Communication] - SDK - Added contributing file (Azure#18018)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

6 participants