[Container Registry] Acr delete tag

sdk/containerregistry/azure-containerregistry/azure/containerregistry/_base_client.py

@@ -31,7 +31,7 @@ class ContainerRegistryBaseClient(object):
 
     """
 
-    def __init__(self, endpoint, credential, **kwargs):  # pylint:disable=client-method-missing-type-annotations
+    def __init__(self, endpoint, credential, **kwargs):
         # type: (str, TokenCredential, Dict[str, Any]) -> None
         auth_policy = ContainerRegistryChallengePolicy(credential, endpoint)
         self._client = ContainerRegistry(

sdk/containerregistry/azure-containerregistry/azure/containerregistry/_container_repository_client.py

@@ -63,14 +63,14 @@ def delete_registry_artifact(self, digest, **kwargs):
 
     def delete_tag(self, tag, **kwargs):
         # type: (str) -> None
-        """Delete a tag
+        """Delete a tag from a repository
 
         :param tag: The digest of the artifact to be deleted
         :type tag: str
         :returns: None
         :raises: :class:~azure.core.exceptions.ResourceNotFoundError
         """
-        raise NotImplementedError("Has not been implemented")
+        self._client.container_registry_repository.delete_tag(self.repository, tag, **kwargs)
 
     def get_properties(self, **kwargs):
         # type: (...) -> RepositoryProperties
@@ -93,7 +93,6 @@ def get_registry_artifact_properties(self, tag_or_digest, **kwargs):
         :returns: :class:~azure.containerregistry.RegistryArtifactProperties
         :raises: :class:~azure.core.exceptions.ResourceNotFoundError
         """
-        # GET '/acr/v1/{name}/_manifests/{digest}'
         if _is_tag(tag_or_digest):
             tag_or_digest = self._get_digest_from_tag(tag_or_digest)
 
@@ -112,7 +111,6 @@ def get_tag_properties(self, tag, **kwargs):
         :returns: :class:~azure.containerregistry.TagProperties
         :raises: :class:~azure.core.exceptions.ResourceNotFoundError
         """
-        # GET '/acr/v1/{name}/_tags/{reference}'
         return TagProperties._from_generated(  # pylint: disable=protected-access
             self._client.container_registry_repository.get_tag_properties(self.repository, tag, **kwargs)
         )

sdk/containerregistry/azure-containerregistry/azure/containerregistry/aio/_async_container_repository_client.py

@@ -3,7 +3,7 @@
 # Copyright (c) Microsoft Corporation.
 # Licensed under the MIT License.
 # ------------------------------------
-from typing import TYPE_CHECKING
+from typing import TYPE_CHECKING, Dict, Any
 
 from azure.core.async_paging import AsyncItemPaged
 
@@ -44,16 +44,15 @@ async def _get_digest_from_tag(self, tag: str) -> None:
         tag_props = await self.get_tag_properties(tag)
         return tag_props.digest
 
-    async def delete(self, **kwargs) -> None:
-        # type: (...) -> None
+    async def delete(self, **kwargs: Dict[str, Any]) -> None:
         """Delete a repository
 
         :returns: None
         :raises: :class:~azure.core.exceptions.ResourceNotFoundError
         """
         await self._client.container_registry.delete_repository(self.repository, **kwargs)
 
-    def delete_registry_artifact(self, digest: str, **kwargs) -> None:
+    async def delete_registry_artifact(self, digest: str, **kwargs) -> None:
         """Delete a registry artifact
 
         :param digest: The digest of the artifact to be deleted
@@ -63,15 +62,15 @@ def delete_registry_artifact(self, digest: str, **kwargs) -> None:
         """
         raise NotImplementedError("Has not been implemented")
 
-    def delete_tag(self, tag: str, **kwargs) -> None:
-        """Delete a tag
+    async def delete_tag(self, tag: str, **kwargs) -> None:
+        """Delete a tag from a repository
 
         :param tag: The digest of the artifact to be deleted
         :type tag: str
         :returns: None
         :raises: :class:~azure.core.exceptions.ResourceNotFoundError
         """
-        raise NotImplementedError("Has not been implemented")
+        await self._client.container_registry_repository.delete_tag(self.repository, tag, **kwargs)
 
     async def get_properties(self, **kwargs) -> RepositoryProperties:
         """Get the properties of a repository

sdk/containerregistry/azure-containerregistry/tests/preparer.py

@@ -0,0 +1,15 @@
+# coding=utf-8
+# ------------------------------------
+# Copyright (c) Microsoft Corporation.
+# Licensed under the MIT License.
+# ------------------------------------
+import functools
+
+from devtools_testutils import AzureTestCase, PowerShellPreparer
+
+acr_preparer = functools.partial(
+    PowerShellPreparer,
+    "containerregistry",
+    containerregistry_baseurl="fake_url.azurecr.io",
+    containerregistry_resource_group="fake_rg",
+)

sdk/containerregistry/azure-containerregistry/tests/recordings/test_container_registry_async.test_delete_repository_does_not_exist.yaml

@@ -19,7 +19,7 @@ interactions:
       connection: keep-alive
       content-length: '209'
       content-type: application/json; charset=utf-8
-      date: Tue, 30 Mar 2021 12:19:01 GMT
+      date: Thu, 01 Apr 2021 17:31:42 GMT
       docker-distribution-api-version: registry/2.0
       server: openresty
       strict-transport-security: max-age=31536000; includeSubDomains
@@ -47,10 +47,11 @@ interactions:
     headers:
       connection: keep-alive
       content-type: application/json; charset=utf-8
-      date: Tue, 30 Mar 2021 12:19:02 GMT
+      date: Thu, 01 Apr 2021 17:31:43 GMT
       server: openresty
       strict-transport-security: max-age=31536000; includeSubDomains
       transfer-encoding: chunked
+      x-ms-ratelimit-remaining-calls-per-second: '333.316667'
     status:
       code: 200
       message: OK
@@ -74,10 +75,11 @@ interactions:
     headers:
       connection: keep-alive
       content-type: application/json; charset=utf-8
-      date: Tue, 30 Mar 2021 12:19:03 GMT
+      date: Thu, 01 Apr 2021 17:31:43 GMT
       server: openresty
       strict-transport-security: max-age=31536000; includeSubDomains
       transfer-encoding: chunked
+      x-ms-ratelimit-remaining-calls-per-second: '333.3'
     status:
       code: 200
       message: OK
@@ -102,11 +104,12 @@ interactions:
       connection: keep-alive
       content-length: '121'
       content-type: application/json; charset=utf-8
-      date: Tue, 30 Mar 2021 12:19:03 GMT
+      date: Thu, 01 Apr 2021 17:31:43 GMT
       docker-distribution-api-version: registry/2.0
       server: openresty
       strict-transport-security: max-age=31536000; includeSubDomains
       x-content-type-options: nosniff
+      x-ms-ratelimit-remaining-calls-per-second: '32.000000'
     status:
       code: 404
       message: Not Found

sdk/containerregistry/azure-containerregistry/tests/recordings/test_container_registry_async.test_list_repositories.yaml

@@ -19,7 +19,7 @@ interactions:
       connection: keep-alive
       content-length: '196'
       content-type: application/json; charset=utf-8
-      date: Tue, 30 Mar 2021 12:19:03 GMT
+      date: Thu, 01 Apr 2021 17:31:43 GMT
       docker-distribution-api-version: registry/2.0
       server: openresty
       strict-transport-security: max-age=31536000; includeSubDomains
@@ -47,10 +47,11 @@ interactions:
     headers:
       connection: keep-alive
       content-type: application/json; charset=utf-8
-      date: Tue, 30 Mar 2021 12:19:04 GMT
+      date: Thu, 01 Apr 2021 17:31:44 GMT
       server: openresty
       strict-transport-security: max-age=31536000; includeSubDomains
       transfer-encoding: chunked
+      x-ms-ratelimit-remaining-calls-per-second: '333.316667'
     status:
       code: 200
       message: OK
@@ -74,10 +75,11 @@ interactions:
     headers:
       connection: keep-alive
       content-type: application/json; charset=utf-8
-      date: Tue, 30 Mar 2021 12:19:04 GMT
+      date: Thu, 01 Apr 2021 17:31:45 GMT
       server: openresty
       strict-transport-security: max-age=31536000; includeSubDomains
       transfer-encoding: chunked
+      x-ms-ratelimit-remaining-calls-per-second: '333.3'
     status:
       code: 200
       message: OK
@@ -93,15 +95,15 @@ interactions:
     uri: https://fake_url.azurecr.io/acr/v1/_catalog
   response:
     body:
-      string: '{"repositories":["alpine/git","debian","hello-world","library/hello-world","ubuntu"]}
+      string: '{"repositories":["alpine/git","debian","hello-world","library/hello-world","repo160e197b","repo308e19dd","repo9b321760","repob7cc1bf8","ubuntu"]}
 
         '
     headers:
       access-control-expose-headers: X-Ms-Correlation-Request-Id
       connection: keep-alive
-      content-length: '86'
+      content-length: '146'
       content-type: application/json; charset=utf-8
-      date: Tue, 30 Mar 2021 12:19:04 GMT
+      date: Thu, 01 Apr 2021 17:31:45 GMT
       docker-distribution-api-version: registry/2.0
       server: openresty
       strict-transport-security: max-age=31536000; includeSubDomains