integrated sdk with generated client + models wrapping #17235
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* [samples] added 'batch_translation_async' sample * [samples] added 'batch_translation_with_storage_async' sample * [samples] added remianing async samples * [samples] update file names * [samples] added self to instance methods * [samples][async] fix import textanalytics :) * [samples] fix self. when calling instance methods * [samples] fixed async check status to use AsyncItemPaged used in Async Client * [samples] async -> some async operations instead of sync ones * [samples][async] use async blob operations * [samples][async] blob download async * [samples][async] check_documents async * [samples][async] added some missing await methods * [async samples] change await time to recommended period * [samples] updated async samples to comply with new changes
…stead of busy wait
Contributor
kristapratico
left a comment
kristapratico
left a comment
There was a problem hiding this comment.
Looking good :) After resolving the merge conflict, let's address any other linting checks that come up in the CI pipeline and then merge!
Contributor
|
There we go, now the CI pipeline is running on this PR. Linter check errors can be found here: https://dev.azure.com/azure-sdk/public/_build/results?buildId=786387&view=logs&j=b70e5e73-bbb6-5567-0939-8415943fadb9&t=56d4e2e6-c43b-527c-bad7-234ebe7429dd |
sdk/documenttranslation/azure-ai-documenttranslation/azure/ai/documenttranslation/_client.py
Outdated
Show resolved
Hide resolved
added 12 commits
March 17, 2021 14:36
sdk/documenttranslation/azure-ai-documenttranslation/azure/ai/documenttranslation/_models.py
Show resolved
Hide resolved
This was referenced Mar 19, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@kristapratico