Rename user_identifier suffix #17178
Conversation
- Initialize CommunicationTokenCredential with token and not with CommunicationTokenRefreshOptions - Convert AccessToken.expires_on to int as compared to datetime
sarkar-rajarshi
requested review from
a team,
ankitarorabit,
memontic-ms and
turalf
as code owners
|
This pull request is protected by Check Enforcer. What is Check Enforcer?Check Enforcer helps ensure all pull requests are covered by at least one check-run (typically an Azure Pipeline). When all check-runs associated with this pull request pass then Check Enforcer itself will pass. Why am I getting this message?You are getting this message because Check Enforcer did not detect any check-runs being associated with this pull request within five minutes. This may indicate that your pull request is not covered by any pipelines and so Check Enforcer is correctly blocking the pull request being merged. What should I do now?If the check-enforcer check-run is not passing and all other check-runs associated with this PR are passing (excluding license-cla) then you could try telling Check Enforcer to evaluate your pull request again. You can do this by adding a comment to this pull request as follows: What if I am onboarding a new service?Often, new services do not have validation pipelines associated with them, in order to bootstrap pipelines for a new service, you can issue the following command as a pull request comment: |
sarkar-rajarshi
changed the base branch from
master
to
feature/communication-chat-preview5
sarkar-rajarshi
changed the title
* Rename user_identifier suffix (#17178) * make CommunicationUserIdentifierSerializer private * CommunicationTokenCredential + AccessToken fix - Initialize CommunicationTokenCredential with token and not with CommunicationTokenRefreshOptions - Convert AccessToken.expires_on to int as compared to datetime * add token_refresher to CommunicationTokenCredential * update docstring * Identifier fields renaming _ credential import fixes in sample code * preview5 models generated - CommunicationError renamed to ChatError * rename ChatThread to ChatThreadProperties * get_chat_thread renamed to get_properties - Rename method - Move get_properties from ChatClient to ChatThreadClient - Change method signature - remove parameter thread_id - Modify unit and e2e tests - move tests from chat_thread_* to chat_thread_client_* - Update README.md * Rename ChatThreadInfo to ChatThreadItem * Remove add_participant * Rename repeatability_request_id to idempotency_token * Change send_message return type from str to SendChatMessageResult * Changes made due to rename of CommunicationError -> ChatError - Changes made due to flattening of CreateChatThreadResult and AddChatParticipantsResult * test recording added * Address PR comments * pylint fixes
2 participants
No description provided.