Skip to content

Conversation

@craigktreasure
Copy link

  • This change updates the minimum version of Azure Core to 1.4.0 to make sure we get a package version that includes AzureKeyCredential to fix the nightly release builds.

Copy link
Contributor

@seankane-msft seankane-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :shipit:

@craigktreasure
Copy link
Author

@seankane-msft Build failed with:

The following libraries declare requirement 'azure-core<2.0.0,>=1.4.0' which does not match the frozen requirement 'azure-core<2.0.0,>=1.2.2':
  * azure-mixedreality-authentication

Any suggestions?

@craigktreasure craigktreasure force-pushed the craig/mr-auth-core-version branch from cc83bae to efdd4a8 Compare February 26, 2021 19:17
  - This change updates the minimum version of Azure Core to 1.4.0 to make sure we get a package version that includes AzureKeyCredential to fix the nightly release builds.
@craigktreasure craigktreasure force-pushed the craig/mr-auth-core-version branch from efdd4a8 to a739469 Compare February 26, 2021 19:35
@scbedd
Copy link
Member

scbedd commented Feb 26, 2021

@craigktreasure I'll come up with something for you. This error doesn't make sense.

@craigktreasure
Copy link
Author

Thanks @scbedd. Looks like that did the trick. Hopefully that version has everything I need.

@ghost
Copy link

ghost commented Feb 26, 2021

Hello @craigktreasure!

Because this pull request has the auto-merge label, I will be glad to assist with helping to merge this pull request once all check-in policies pass.

p.s. you can customize the way I help with merging this pull request, such as holding this pull request until a specific person approves. Simply @mention me (@msftbot) and give me an instruction to get started! Learn more here.

@ghost ghost merged commit 8cb6c41 into Azure:master Feb 26, 2021
@craigktreasure craigktreasure deleted the craig/mr-auth-core-version branch February 26, 2021 23:35
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Mar 1, 2021
…into correct_healthcare

* 'master' of https://github.com/Azure/azure-sdk-for-python: (30 commits)
  [EventGrid] Improve docs (Azure#16986)
  Fixed delete_blob method signature (Azure#16983)
  Fixed Content-MD5 serialization and typing (Azure#16987)
  [eventgrid] Black formatting and tests suite (Azure#16989)
  Appconfig perf test (Azure#16809)
  adds support for milliseconds on datetime objects (Azure#16847)
  [ServiceBus] Improve AMQP Error handling (Azure#16427)
  T2 resource 2021 02 26 (Azure#16961)
  T2 servicefabricmanagedclusters 2021 02 26 (Azure#16958)
  Update Prepare-Release script (Azure#16976)
  the previous filter was erroneously filtering out real files. (Azure#16978)
  Update azure-core minimum version (Azure#16968)
  update documention in depends section of eng_sys_checks.md (Azure#16967)
  version (Azure#16959)
  T2 web 2021 02 24 (Azure#16901)
  Change test pipeline to run in eastus2 (Azure#16950)
  Adding azure-devtools to mr-auth dev_requirements (Azure#16953)
  Add perf tests for eventgrid (Azure#16949)
  temp fix for canary tests (Azure#16945)
  Update get_package_properties to also return path to setup.py (Azure#16946)
  ...
This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants