Skip to content

Fixing credentials to use AAD #16885

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
seankane-msft merged 5 commits into from
Mar 2, 2021
Merged

Fixing credentials to use AAD #16885

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
69f6b68
fixed credentials to use aad for the aad tests
seankane-msft Feb 23, 2021
82a6f68
undoing changes to async wrapper
seankane-msft Feb 23, 2021
03d01dc
small cleanups and removing unnecessary code
seankane-msft Feb 23, 2021
a531cab
removing an import
seankane-msft Feb 23, 2021
41ec457
removing more imports
seankane-msft Feb 23, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
10 changes: 2 additions & 8 deletions sdk/appconfiguration/azure-appconfiguration/tests/async_wrapper.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,14 +6,9 @@
# --------------------------------------------------------------------------
from devtools_testutils import PowerShellPreparer

from azure.appconfiguration import (
ResourceReadOnlyError,
ConfigurationSetting,
)
from azure.appconfiguration import ConfigurationSetting
from azure.appconfiguration.aio import AzureAppConfigurationClient
from azure.core.exceptions import (
AzureError,
)
from azure.core.exceptions import AzureError
from consts import (
KEY,
LABEL,
Expand Down Expand Up @@ -67,7 +62,6 @@ def trim_kwargs_from_test_function(fn, kwargs):
for key in [k for k in kwargs if k not in args]:
del kwargs[key]


def app_config_decorator(func, **kwargs):

@AppConfigPreparer()
Expand Down
4 changes: 2 additions & 2 deletions sdk/appconfiguration/azure-appconfiguration/tests/test_azure_configuration_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -4,7 +4,7 @@
# license information.
# --------------------------------------------------------------------------
from azure.core import MatchConditions
from devtools_testutils import AzureMgmtTestCase, PowerShellPreparer
from devtools_testutils import AzureTestCase, PowerShellPreparer
from azure.core.exceptions import (
ResourceModifiedError,
ResourceNotFoundError,
Expand Down Expand Up @@ -35,7 +35,7 @@
import re
import functools

class AppConfigurationClientTest(AzureMgmtTestCase):
class AppConfigurationClientTest(AzureTestCase):
def __init__(self, method_name):
super(AppConfigurationClientTest, self).__init__(method_name)
self.vcr.match_on = ["path", "method", "query"]
Expand Down
Loading