Skip to content

Conversation

@abhahn
Copy link
Contributor

@abhahn abhahn commented Feb 18, 2021

No description provided.

base_url = '{Endpoint}/text/analytics/v3.0'
elif api_version == 'v3.1-preview.3':
base_url = '{Endpoint}/text/analytics/v3.1-preview.3'
elif api_version == 'v3.1-preview.4':
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are we going to bump the version here like we did before for v3.1-preview.4 (i.e. removing support for other API versions)?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For now I've added this back in to prevent existing tests from failing. It will be easier to remove this later once updates to Healthcare and Analyze have been merged, because the tests will be updated to reflect the changes.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah @abhahn you made the right call. We need to keep v3.1-preview.3 and 4 for now, but once 4 is released we should get rid of 3

Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @abhahn

@iscai-msft iscai-msft merged commit db80092 into Azure:feature/textanalytics-5.1.0.b6 Feb 19, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants