[Communication] - Phone Number - Redesigned API #16671
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jbeauregardb
requested review from
a team,
ankitarorabit,
memontic-ms and
turalf
as code owners
ghost
added
the
annatisch
previously requested changes
Feb 15, 2021
Member
annatisch
left a comment
annatisch
left a comment
There was a problem hiding this comment.
Could we please get an updated APIview for these changes? :)
...n/azure-communication-phonenumbers/azure/communication/phonenumbers/_phone_numbers_client.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-phonenumbers/azure/communication/phonenumbers/__init__.py
Outdated
Show resolved
Hide resolved
...n/azure-communication-phonenumbers/azure/communication/phonenumbers/_phone_numbers_client.py
Outdated
Show resolved
Hide resolved
...n/azure-communication-phonenumbers/azure/communication/phonenumbers/_phone_numbers_client.py
Outdated
Show resolved
Hide resolved
...n/azure-communication-phonenumbers/azure/communication/phonenumbers/_phone_numbers_client.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-phonenumbers/samples/get_phone_number_sample.py
Outdated
Show resolved
Hide resolved
...communication/azure-communication-phonenumbers/samples/list_acquired_phone_numbers_sample.py
Outdated
Show resolved
Hide resolved
jbeauregardb
force-pushed
the
pnm-redesign
branch
from
9b3b232 to
cb958a4
Compare
turalf
reviewed
Feb 19, 2021
sdk/communication/azure-communication-phonenumbers/samples/get_phone_number_sample.py
Outdated
Show resolved
Hide resolved
...nenumbers/test/recordings/test_phone_number_administration_client.test_get_phone_number.yaml
Outdated
Show resolved
Hide resolved
...cordings/test_phone_number_administration_client_async.test_list_acquired_phone_numbers.yaml
Outdated
Show resolved
Hide resolved
...test/recordings/test_phone_number_administration_client_async.test_release_phone_number.yaml
Outdated
Show resolved
Hide resolved
...n/azure-communication-phonenumbers/azure/communication/phonenumbers/_phone_numbers_client.py
Outdated
Show resolved
Hide resolved
jbeauregardb
requested review from
00Kai0,
abhahn,
amishra-dev,
cRui861,
catalinaperalta,
changlong-liu,
chlowell,
danieljurek,
dpwatrous,
giakas,
gingi,
iscai-msft,
johanste,
jsntcy,
kasobol-msft,
kristapratico,
lmazuel,
lzchen,
mayurid,
mccoyp,
mitchdenny and
msyyc
as code owners
jbeauregardb
force-pushed
the
pnm-redesign
branch
from
40239b1 to
a7d0a0c
Compare
beltr0n
requested changes
Mar 5, 2021
...munication/azure-communication-phonenumbers/samples/search_available_phone_numbers_sample.py
Outdated
Show resolved
Hide resolved
...nication/azure-communication-phonenumbers/samples/update_phone_number_capabilities_sample.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-phonenumbers/test/_shared/testcase.py
Outdated
Show resolved
Hide resolved
...one_number_administration_client.test_list_acquired_phone_numbers_from_managed_identity.yaml
Outdated
Show resolved
Hide resolved
sacheu
reviewed
Mar 5, 2021
There was a problem hiding this comment.
Is this common practice to have import class from generated code as XXXGen?
sacheu
reviewed
Mar 5, 2021
sdk/communication/azure-communication-phonenumbers/samples/get_phone_number_sample.py
Outdated
Show resolved
Hide resolved
sacheu
reviewed
Mar 5, 2021
There was a problem hiding this comment.
Is 'import {A class} as {A Class}Gen' a common practice? why we need to do this?
I don't see next line is doing the same
Contributor
Author
There was a problem hiding this comment.
It's also done in the Identity client and it was also done in the previous implementation of this PNM SDK, so I just left it as it was
|
Do we need to re-enable LIve TEST for phone number in this PR? I don't see that change? |
|
No need to checkin ...on/azure-communication-identity/azure_communication_identity-1.0.0b4-py2.py3-none-any.whl since it is empty file. |
jbeauregardb
force-pushed
the
pnm-redesign
branch
from
22a2651 to
563859b
Compare
Contributor
Author
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jbeauregardb
force-pushed
the
pnm-redesign
branch
2 times, most recently
from
6fa85e3 to
471f511
Compare
Contributor
Author
|
/azp run python - communication - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
jbeauregardb
force-pushed
the
pnm-redesign
branch
from
471f511 to
e268c60
Compare
beltr0n
approved these changes
Mar 5, 2021
jbeauregardb
force-pushed
the
pnm-redesign
branch
from
9741e19 to
b14ef4d
Compare
iscai-msft
added a commit
that referenced
this pull request
Mar 8, 2021
…into update_ta_tests * 'master' of https://github.com/Azure/azure-sdk-for-python: Update get_package_properties.py logic for python 2.7 (#17144) update changelog (#17150) [ServiceBus] 7.1.0 Release update changelog (#17135) [ServiceBus] Object mapping support (#17080) move SetTestPipeline into its own template (#17141) Revise token cache configuration API (#16326) Fix dup cloud error (#17097) Perf tests for monitor exporter (#17067) [Communication] - Phone Number - Redesigned API (#16671) disable retry (#17078) [Key Vault] Add perf tests for certificates, keys, and secrets (#17073) [text analytics] Analyze updates for v5.1.0b6 (#17003) Add any additional claims to AuthenticationRequiredError (#17136) Fix logic in SetTestPipelineVersionInEngCommon (#17138) [Key Vault] Make test resource cleanup script asynchronous (#17032)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
6 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR has the new redesign for the PNM package.