added contains to DictMixin #16604
Merged
added contains to DictMixin #16604
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mshaban-msft
requested review from
abhahn,
iscai-msft and
kristapratico
as code owners
ghost
added
the
Contributor
|
@mohamedshabanofficial we don't have a separate folder for unittests, we just add them in the same folder. This is def something we can look into changing, but for now I would jsut add them in the same folder. Example unit tests here |
Contributor
|
and @mohamshabanofficial this looks good! I'm going to hold off on merging any of these code-changing TA PRs until after our release on Tuesday. Thanks! |
iscai-msft
approved these changes
Feb 12, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
where to add unit tests in the project?
i mean like almost all tests are integration tests