Skip to content

Conversation

@abhahn
Copy link
Contributor

@abhahn abhahn commented Feb 4, 2021

No description provided.

Copy link
Contributor

@iscai-msft iscai-msft left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@abhahn looks good, I would jsut add an entry into the changelog.md before merging, should be added under "new features"

- No longer need to specify `api_version=TextAnalyticsApiVersion.V3_1_PREVIEW_3` when calling `begin_analyze` and `begin_analyze_healthcare`. `begin_analyze_healthcare` is still in gated preview though.

- Added a new parameter `string_index_type` to the service client methods `begin_analyze_healthcare`, `analyze_sentiment`, `recognize_entities`, `recognize_pii_entities`, and `recognize_linked_entities`.
- Added property `length` from `CategorizedEntity`, `SentenceSentiment`, `LinkedEntityMatch`, `AspectSentiment`, `OpinionSentiment`, `PiiEntity` and
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: Added property length to... wouldn't have mentioned it, but looks like you need to solve a merge conflict either way.

…into expose_length

* 'master' of https://github.com/Azure/azure-sdk-for-python:
  [textanalytics] add :keyword: to docstrings for TextDocumentInput and DetectLanguageInput (Azure#16542)
  [SB] combine conn str parser logic in base handler and _common (Azure#16464)
  [text analytics] add analyze readme bullet point (Azure#16552)
  resolve issues with failing search documents on mindependency checks (Azure#16553)
  [text analytics] analyze changes (Azure#16418)
  [Core] Added enum meta class (Azure#16316)
  Adding missing supported fields to invoice sample (Azure#16547)
  Update EventHub ci.yml to skip unsupported pypy3 (Azure#16545)
  patching the publishing of artifacts only on successful run (Azure#16539)
  need to bump msrest up one (Azure#16544)
  [EventHub&ServiceBUs] Update readme pointing to uamqp installation guidance (added alpine installation) (Azure#16515)
  add dotenv as a dep for azure-sdk-tools (Azure#16532)
  skip prebuilt from_url tests for now (Azure#16534)
  Latest/Minimum filter retrieved packages by pyVersion compatibility (Azure#16510)
  CertificateCredential accepts certs as bytes (Azure#16410)
@iscai-msft iscai-msft merged commit 3be037d into Azure:master Feb 5, 2021
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Feb 5, 2021
…into new_polling

* 'master' of https://github.com/Azure/azure-sdk-for-python: (250 commits)
  Converting to pure unit tests (Azure#16499)
  Fix replace keys for nested json (Azure#16557)
  update release date (Azure#16543)
  Feature/communication chat preview3 new model (Azure#16561)
  [text analytics] Exposed the length property in classes impacted by `string_index_type` (Azure#16538)
  [textanalytics] add :keyword: to docstrings for TextDocumentInput and DetectLanguageInput (Azure#16542)
  [SB] combine conn str parser logic in base handler and _common (Azure#16464)
  [text analytics] add analyze readme bullet point (Azure#16552)
  resolve issues with failing search documents on mindependency checks (Azure#16553)
  [text analytics] analyze changes (Azure#16418)
  [Core] Added enum meta class (Azure#16316)
  Adding missing supported fields to invoice sample (Azure#16547)
  Update EventHub ci.yml to skip unsupported pypy3 (Azure#16545)
  patching the publishing of artifacts only on successful run (Azure#16539)
  need to bump msrest up one (Azure#16544)
  [EventHub&ServiceBUs] Update readme pointing to uamqp installation guidance (added alpine installation) (Azure#16515)
  add dotenv as a dep for azure-sdk-tools (Azure#16532)
  skip prebuilt from_url tests for now (Azure#16534)
  Latest/Minimum filter retrieved packages by pyVersion compatibility (Azure#16510)
  CertificateCredential accepts certs as bytes (Azure#16410)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants