-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Add Cloud environment for Teams user #16359
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
41 commits
Select commit
Hold shift + click to select a range
2f6289a
Add cloud environment enum
9898c8f
Add cloud environemnt to CommunicationIdentifierModel
0b4df96
Rename CommunicationCloudEnvironment
77c3689
Add cloud environemtn to serialize/deserialzie
f360d21
Rearrange microsoft teams user class position
b987067
Rename the kwarg name
d059b55
Add cloud env into tests
ac44487
Fix typos in identifier kind enums
15b844d
Add cloud to serialize/deserialize tests for teams user
f4caf9c
remove unused import
d97e8f8
Add identifier to the identifier to the microsoft teams user model
09a47b8
Add idenitifier to the phone number
1bd495f
Add ids to the tests
c12bce4
Make id mandatory for deserilize
b1c9b34
Fix lint error
3309e69
Add identifier to the doc string
fa4ffaa
Throw when identifier type is not supported
2cd2e41
Fix typo in test name
e65ce70
Add test_serialize_foreign_throws
a6b0e10
Add test for unknown kind
5ee9907
Fix docstring for serialize method
3792c89
Fix the typo in anonymous
903f7eb
Fix phone number doc string
fb9003e
Sync model to admin and chat
cfb85a0
Fix the docstring for CommunicationIdentifierModel
8dabd70
Remove dev-tools
dd759ad
add mgmt core to setup py for mgmt package
61e3341
Update the core dependency in mgmt package.
92a6c14
Sync models to admin, sms, identity
6cb8d97
Change the exception message
d7ee2b4
Add idnetifier check in the test
0bd0a12
sync model to other packages
9c8cae6
Remove unnecessary mgmt dependency
3cd86b7
change identity to identifier in docstrings
c881ca4
change core forzen requirement for identity
088b41d
Change docstring for sms
c0bbf9c
Override shared reqs for core
624b3cc
Fix forzen requirements for core and sms
22b727e
change core dependency version in chat,sms,admin
6b6a902
Add mgmt core back to the dependency
d703523
Add a new line at the end of file
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
sdk/communication/azure-communication-administration/dev_requirements.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1 change: 0 additions & 1 deletion
1
sdk/communication/azure-communication-chat/dev_requirements.txt
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.