[Event Hubs] created EventHubConnectionStringProperties and connection string parser #16204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
Author
|
/azp run python - eventhub - tests |
|
No pipelines are associated with this pull request. |
|
Azure Pipelines successfully started running 1 pipeline(s). |
rakshith91
reviewed
Jan 21, 2021
rakshith91
reviewed
Jan 21, 2021
rakshith91
reviewed
Jan 21, 2021
sdk/eventhub/azure-eventhub/tests/unittest/test_connection_string_parser.py
Show resolved
Hide resolved
rakshith91
approved these changes
Jan 21, 2021
Contributor
rakshith91
left a comment
rakshith91
left a comment
There was a problem hiding this comment.
LGTM - make sure @yunhaoling signs it off too before you merge it :)
yunhaoling
reviewed
Jan 21, 2021
sdk/eventhub/azure-eventhub/azure/eventhub/_connection_string_parser.py
Outdated
Show resolved
Hide resolved
Member
Author
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Member
Author
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
yunhaoling
reviewed
Jan 22, 2021
sdk/eventhub/azure-eventhub/azure/eventhub/_connection_string_parser.py
Outdated
Show resolved
Hide resolved
Co-authored-by: Adam Ling (MSFT) <[email protected]>
annatisch
approved these changes
Jan 25, 2021
Member
annatisch
left a comment
annatisch
left a comment
There was a problem hiding this comment.
LGTM
Just to clarify - this isn't replacing the from_connection_string classmethods is it? Just supplementary?
Member
Author
|
@annatisch nope! It's just supplementary, to "assist with transforming a connection string for use with credential-based client creation". |
Member
Author
|
/azp run python - eventhub - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressing: #14575
following the SB Connection String parser: #14574