Skip to content

Sync eng/common directory with azure-sdk-tools for PR 1302 #16009

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
azure-sdk merged 4 commits into from
Jan 7, 2021
Merged

Sync eng/common directory with azure-sdk-tools for PR 1302 #16009

Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
77ceab4
Make the user agent configurable.
sima-zhu Jan 6, 2021
621ae9c
Address comments
sima-zhu Jan 7, 2021
3037cc6
Default to current Chrome version
sima-zhu Jan 7, 2021
8cbd3e2
Revert the yaml file changes
sima-zhu Jan 7, 2021
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
13 changes: 9 additions & 4 deletions eng/common/scripts/Verify-Links.ps1
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -18,13 +18,18 @@ param (
# the substitute branch name or SHA commit
[string] $branchReplacementName = "",
# flag to allow checking against azure sdk link guidance. Check link guidance here: https://aka.ms/azsdk/guideline/links
[bool] $checkLinkGuidance = $false
[bool] $checkLinkGuidance = $false,
# UserAgent to be configured for web request. Default to current Chrome version.
[string] $userAgent
)

$ProgressPreference = "SilentlyContinue"; # Disable invoke-webrequest progress dialog
# Regex of the locale keywords.
$locale = "/en-us/"
$emptyLinkMessage = "There is at least one empty link in the page. Please replace with absolute link. Check here for more information: https://aka.ms/azsdk/guideline/links"
if (!$userAgent) {
$userAgent = "Chrome/87.0.4280.88"
}
function NormalizeUrl([string]$url){
if (Test-Path $url) {
$url = "file://" + (Resolve-Path $url).ToString();
Expand Down Expand Up @@ -162,14 +167,14 @@ function CheckLink ([System.Uri]$linkUri)
$headRequestSucceeded = $true
try {
# Attempt HEAD request first
$response = Invoke-WebRequest -Uri $linkUri -Method HEAD
$response = Invoke-WebRequest -Uri $linkUri -Method HEAD -UserAgent $userAgent
}
catch {
$headRequestSucceeded = $false
}
if (!$headRequestSucceeded) {
# Attempt a GET request if the HEAD request failed.
$response = Invoke-WebRequest -Uri $linkUri -Method GET
$response = Invoke-WebRequest -Uri $linkUri -Method GET -UserAgent $userAgent
}
$statusCode = $response.StatusCode
if ($statusCode -ne 200) {
Expand Down Expand Up @@ -239,7 +244,7 @@ function GetLinks([System.Uri]$pageUri)
{
if ($pageUri.Scheme.StartsWith("http")) {
try {
$response = Invoke-WebRequest -Uri $pageUri
$response = Invoke-WebRequest -Uri $pageUri -UserAgent $userAgent
$content = $response.Content
}
catch {
Expand Down