adding an option to use preparers as a back up plan #15945
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
Contributor
Author
Contributor
Author
|
/azp run python - core - ci |
|
Azure Pipelines successfully started running 1 pipeline(s). |
lmazuel
reviewed
Dec 29, 2020
| raise AzureTestError(template.format(key)) | ||
| except KeyError as key_error: | ||
| if not self._backup_preparers: | ||
| raise key_error |
Member
There was a problem hiding this comment.
Just raise, this is re-raising the latest exception automatically. I believe this is equivalent but convention when you mostly let it go is to just write raise. Though I wonder if the stacktrace is impacted when you put a variable name like key_error in between.
lmazuel
approved these changes
Dec 30, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a environment variable kwarg is not present, the preparer will go to the backup plan of provided preparers if they are provided.