Skip to content

[Storage]Avoid incorrect padding Error when base64 decode account key #15782

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
xiafu-msft wants to merge 1 commit into from
Closed

[Storage]Avoid incorrect padding Error when base64 decode account key #15782

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion sdk/storage/azure-storage-blob/azure/storage/blob/_shared/authentication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ def _get_canonicalized_resource_query(request):

def _add_authorization_header(self, request, string_to_sign):
try:
signature = sign_string(self.account_key, string_to_sign)
padding = '=' * (4 - len(self.account_key) % 4)
signature = sign_string(self.account_key + padding, string_to_sign)
auth_string = 'SharedKey ' + self.account_name + ':' + signature
request.http_request.headers['Authorization'] = auth_string
except Exception as ex:
Expand Down
3 changes: 2 additions & 1 deletion sdk/storage/azure-storage-file-datalake/azure/storage/filedatalake/_shared/authentication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ def _get_canonicalized_resource_query(request):

def _add_authorization_header(self, request, string_to_sign):
try:
signature = sign_string(self.account_key, string_to_sign)
padding = '=' * (4 - len(self.account_key) % 4)
signature = sign_string(self.account_key + padding, string_to_sign)
auth_string = 'SharedKey ' + self.account_name + ':' + signature
request.http_request.headers['Authorization'] = auth_string
except Exception as ex:
Expand Down
3 changes: 2 additions & 1 deletion sdk/storage/azure-storage-file-share/azure/storage/fileshare/_shared/authentication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ def _get_canonicalized_resource_query(request):

def _add_authorization_header(self, request, string_to_sign):
try:
signature = sign_string(self.account_key, string_to_sign)
padding = '=' * (4 - len(self.account_key) % 4)
signature = sign_string(self.account_key + padding, string_to_sign)
auth_string = 'SharedKey ' + self.account_name + ':' + signature
request.http_request.headers['Authorization'] = auth_string
except Exception as ex:
Expand Down
3 changes: 2 additions & 1 deletion sdk/storage/azure-storage-queue/azure/storage/queue/_shared/authentication.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -115,7 +115,8 @@ def _get_canonicalized_resource_query(request):

def _add_authorization_header(self, request, string_to_sign):
try:
signature = sign_string(self.account_key, string_to_sign)
padding = '=' * (4 - len(self.account_key) % 4)
signature = sign_string(self.account_key + padding, string_to_sign)
auth_string = 'SharedKey ' + self.account_name + ':' + signature
request.http_request.headers['Authorization'] = auth_string
except Exception as ex:
Expand Down