Skip to content

[SQL] 2017-10-24#1570

Merged
lmazuel merged 1 commit intoAzure:masterfrom
lmazuel:sql20171024
Oct 25, 2017
Merged

[SQL] 2017-10-24#1570
lmazuel merged 1 commit intoAzure:masterfrom
lmazuel:sql20171024

Conversation

@lmazuel
Copy link
Copy Markdown
Member

@lmazuel lmazuel commented Oct 24, 2017

FYI @jaredmoo

@lmazuel
Copy link
Copy Markdown
Member Author

lmazuel commented Oct 24, 2017

@jaredmoo
Copy link
Copy Markdown
Contributor

Looks good, @emgu-msft and @maboja-msft to also review

@maboja-msft
Copy link
Copy Markdown

Looks good from my perspective as well.

@lmazuel lmazuel merged commit 821bcc5 into Azure:master Oct 25, 2017
@codecov-io
Copy link
Copy Markdown

codecov-io commented Oct 25, 2017

Codecov Report

Merging #1570 into master will decrease coverage by 0.32%.
The diff coverage is 26.92%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1570      +/-   ##
==========================================
- Coverage   54.17%   53.84%   -0.33%     
==========================================
  Files        3612     3626      +14     
  Lines       89128    89881     +753     
==========================================
+ Hits        48285    48400     +115     
- Misses      40843    41481     +638
Impacted Files Coverage Δ
...mgmt/sql/models/elastic_pool_edition_capability.py 55.55% <0%> (-6.95%) ⬇️
...mt-sql/azure/mgmt/sql/models/edition_capability.py 55.55% <0%> (-6.95%) ⬇️
...e-mgmt-sql/azure/mgmt/sql/sql_management_client.py 100% <100%> (ø) ⬆️
azure-mgmt-sql/azure/mgmt/sql/version.py 100% <100%> (ø) ⬆️
...ure-mgmt-sql/azure/mgmt/sql/operations/__init__.py 100% <100%> (ø) ⬆️
azure-mgmt-sql/azure/mgmt/sql/models/database.py 100% <100%> (ø) ⬆️
azure-mgmt-sql/azure/mgmt/sql/models/__init__.py 100% <100%> (ø) ⬆️
...mt/sql/operations/server_dns_aliases_operations.py 13.93% <13.93%> (ø)
...ure-mgmt-sql/azure/mgmt/sql/models/elastic_pool.py 33.33% <50%> (-2.39%) ⬇️
...t-sql/azure/mgmt/sql/models/elastic_pool_update.py 33.33% <50%> (-2.39%) ⬇️
... and 52 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 946afa9...6dc0a08. Read the comment docs.

@lmazuel lmazuel deleted the sql20171024 branch November 7, 2017 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants