Refactor begin_reserve_phone_numbers() by flattening CreateSearchOptions into args #15378
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangyan99
reviewed
Nov 18, 2020
Member
There was a problem hiding this comment.
Do we need to add this change into changelog?
xiangyan99
reviewed
Nov 18, 2020
Member
There was a problem hiding this comment.
It is a poller rather than a response, right?
HeliWang
requested review from
a team,
RezaJooyandeh and
ankitarorabit
as code owners
HeliWang
force-pushed
the
feature/communication
branch
from
19c732c to
8a00feb
Compare
xiangyan99
approved these changes
Nov 24, 2020
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Aug 2, 2021
Service Fabric Managed Clusters - API version 2021-07-01-preview (Azure#15378) * initial commit - copy from 2021-05-01 * update to version 2021-07-01-preview * update examples * change node type sku list example name * missing type objects * more missing type objects * make skus path pagable Co-authored-by: Alfredo Santamaria Gomez <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Create a draft PR to review the wording of comment for args in begin_reserve_phone_numbers()
Still need to update generated unit test yaml files.
Still need to update async methods