[Communication] - Chat - Replaced CommunicationUserCredentialPolicy with BearerTokenCredentialPolicy#15290
Merged
jbeauregardb merged 7 commits intoAzure:masterfrom Dec 3, 2020
Merged
Conversation
jbeauregardb
requested review from
a team,
RezaJooyandeh,
ankitarorabit,
lmazuel,
mayurid and
turalf
as code owners
jbeauregardb
force-pushed
the
bearerToken
branch
3 times, most recently
from
b7cb990 to
f4a6f96
Compare
Member
There was a problem hiding this comment.
You can probably remove this now
jbeauregardb
force-pushed
the
bearerToken
branch
7 times, most recently
from
00368a0 to
19e3e91
Compare
…Policy in Chat SDK
jbeauregardb
force-pushed
the
bearerToken
branch
from
19e3e91 to
0b10aad
Compare
turalf
reviewed
Nov 19, 2020
| self._client = AzureCommunicationChatService( | ||
| self._endpoint, | ||
| authentication_policy=CommunicationUserCredentialPolicy(self._credential), | ||
| authentication_policy=BearerTokenCredentialPolicy(self._credential, ""), |
Contributor
There was a problem hiding this comment.
Let's check if we need to pass scopes to the constructor. if not we can omit this param.
Contributor
Author
There was a problem hiding this comment.
Scopes is not necessary, will remove it now 👍🏻
sdk/communication/azure-communication-chat/azure/communication/chat/_chat_thread_client.py
Outdated
Show resolved
Hide resolved
sdk/communication/azure-communication-chat/azure/communication/chat/aio/_chat_client_async.py
Show resolved
Hide resolved
...unication/azure-communication-chat/azure/communication/chat/aio/_chat_thread_client_async.py
Outdated
Show resolved
Hide resolved
jbeauregardb
force-pushed
the
bearerToken
branch
from
9a7bb62 to
463b859
Compare
jbeauregardb
force-pushed
the
bearerToken
branch
3 times, most recently
from
db3b4e4 to
b81b449
Compare
turalf
reviewed
Dec 2, 2020
Contributor
There was a problem hiding this comment.
what if we add this method into the utils.py in this folder, and make this conversion during the token creation? Would that work? If that is the case you would not need to call this conversion method every time you return, as the token will be created with the int expires_on field
jbeauregardb
force-pushed
the
bearerToken
branch
from
b81b449 to
eba5360
Compare
jbeauregardb
force-pushed
the
bearerToken
branch
from
eba5360 to
5a7ae43
Compare
jbeauregardb
force-pushed
the
bearerToken
branch
from
5a7ae43 to
d094030
Compare
turalf
approved these changes
Dec 3, 2020
openapi-sdkautomation bot
pushed a commit
to AzureSDKAutomation/azure-sdk-for-python
that referenced
this pull request
Jul 23, 2021
Vipinhas/add min capacity clusters (Azure#15290) * removing read only property, no longer in use - NOT a breaking change * add min value for LA cluster capacity reservation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.