[Identity] Make pipeline policy configurable via kwargs #15248
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In track 2 SDKs,
logging_policyandhttp_logging_policyare configurable viakwargspassed toSubscriptionClientConfiguration.__init__:azure-sdk-for-python/sdk/resources/azure-mgmt-resource/azure/mgmt/resource/subscriptions/v2019_11_01/_configuration.py
Lines 57 to 58 in 27e4203
Azure Identity hard-codes
HttpLoggingPolicywhile creatingpolicies, making it impossible to replaceHttpLoggingPolicywithSansIOHTTPPolicywithout overriding the wholepolicies. (I have to override the wholepoliciesin order to replaceHttpLoggingPolicywithSansIOHTTPPolicy.)azure-sdk-for-python/sdk/identity/azure-identity/azure/identity/_internal/msal_client.py
Lines 124 to 132 in fdf11b3
Azure Identity should follow the same pattern and make individual policies configurable, especially for
http_logging_policywhich is required for Azure CLI to disable logs fromHttpLoggingPolicy, as it is a redacted/duplicated version ofNetworkTraceLoggingPolicy.More detail