Python functionality for Test Resources Preparer script #15227
Conversation
…nce for where this code should live
…emaregistry but fails when running against multiple tests
…bed values, working powershell preparer for cosmos that passes in one file
seankane-msft
requested review from
danieljurek,
scbedd and
weshaggard
as code owners
…ly in the powershell preparer
…ent failures on tests against the recordings
…into powershell-script
This comment has been minimized.
This comment has been minimized.
…urces.ps1 script. appconfigs resources recipe added in
| InjectedPackages: ${{ parameters.InjectedPackages }} | ||
| BuildDocs: ${{parameters.BuildDocs}} | ||
| # figure out what's up with the create resource group above | ||
| - ${{ if eq(parameters['AllocateResourceGroup'], 'false') }}: |
There was a problem hiding this comment.
We might want to add another parameter something like DeployArmTemplate or something like that as I don't think AllocateResourceGroup=false really tells folks what is happening. I think a better name will help folks understand what is happening. You can keep the AllocateResourceGroup for back-compat (assuming there is someone explicitly setting it), but in either case we probably should make the deployment model mutually exclusive so we don't end up deploying via both mechanisms.
…ting tables, schemareg, appconfig tests.yml files
sdk/tables/tests.yml
Outdated
| BuildTargetingString: azure-data-tables | ||
| ServiceDirectory: tables | ||
| AllocateResourceGroup: 'false' | ||
| DeployArmTemplate: 'true' |
There was a problem hiding this comment.
We should remove the AllocateResourceGroup false here and just by the fact someone set DeployArmTemplate we know not to allocate the resource group. (Similarly in the other tests.yml).
There was a problem hiding this comment.
For this specific library, both the ResourceGroup and the ArmTemplate are used for testing. I will work to making them all dependent on the ArmTemplate, but there are ~20 test files for Tables that I would need to fix. This will be done in a separate PR unless absolutely adamant about having one or the other.
There was a problem hiding this comment.
Hmm... so tables is using both the arm template and the allocate resource group? If that is the case then why is allocate resource group set to false? If there are cases were both are needed then I'm find cleaning them up later, but I think it would be good to get everything using one or the other. In fact the next step could be to completely eliminate the AllocationResoureGroup step and replace it with a common template that only setups up a resource group.
There was a problem hiding this comment.
Hmm...you're right I was misunderstanding. The Preparers go through and create resource groups/storage accounts.
To your other points, libraries will use one or the other (either the ArmTemplate in combo with the PowerShellPreparer or the specialized Preparers for the specific service). I can open tracking issues into what libraries still rely on the AllocateResourceGroup and work on replacing with a common template.
tools/azure-sdk-tools/devtools_testutils/powershell_preparer.py
Outdated
Show resolved
Hide resolved
tools/azure-sdk-tools/devtools_testutils/powershell_preparer.py
Outdated
Show resolved
Hide resolved
tools/azure-sdk-tools/devtools_testutils/powershell_preparer.py
Outdated
Show resolved
Hide resolved
|
/azp run python - appconfiguration - tests |
|
Azure Pipelines successfully started running 1 pipeline(s). |
|
/azp run python - scemaregistry- tests |
|
No pipelines are associated with this pull request. |
* CodeGen from PR 15227 in Azure/azure-rest-api-specs config (#15227) * version,CHANGELOG Co-authored-by: SDKAuto <[email protected]> Co-authored-by: PythonSdkPipelines <PythonSdkPipelines>
4 participants
No description provided.