Skip to content

[ServiceBus] Settlement move from Message to Receiver #14681

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
yunhaoling merged 18 commits into from
Nov 2, 2020
Merged

[ServiceBus] Settlement move from Message to Receiver #14681

yunhaoling merged 18 commits into from
Nov 2, 2020

Conversation

@yunhaoling
Copy link
Contributor

@yunhaoling yunhaoling commented Oct 22, 2020 •
edited
Loading

addressing issues:
#14815
#14567

  • Removed class PeekedMessage.
  • Removed class ReceivedMessage under module azure.servicebus.aio.
  • Message settlement methods are moved from ServiceBusMessage to ServiceBusReceiver:
    • Use ServiceBusReceiver.complete_message instead of ServiceBusReceivedMessage.complete to complete a message.
    • Use ServiceBusReceiver.abandon_message instead of ServiceBusReceivedMessage.abandon to abandon a message.
    • Use ServiceBusReceiver.defer_message instead of ServiceBusReceivedMessage.defer to defer a message.
    • Use ServiceBusReceiver.dead_letter_message instead of ServiceBusReceivedMessage.dead_letter to dead letter a message.
  • Message renew_lock method is moved from ServiceBusMessage to ServiceBusReceiver:
    • Changed ServiceBusReceivedMessage.renew_lock to ServiceBusReceiver.renew_message_lock
  • AutoLockRenewer.register now takes ServiceBusReceiver as a positional parameter.

Note
This PR doesn't include auto_lock_renewer opted into the receiver, it would be a separate PR

@ghost ghost added the Service Bus label Oct 22, 2020
@yunhaoling
Copy link
Contributor Author

yunhaoling commented Oct 29, 2020

/azp run python - servicebus - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 29, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@yunhaoling yunhaoling marked this pull request as ready for review October 29, 2020 05:03
@yunhaoling yunhaoling requested a review from rakshith91 October 29, 2020 05:04
@yunhaoling
Copy link
Contributor Author

yunhaoling commented Oct 29, 2020

/azp run python - servicebus - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Oct 29, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@yunhaoling yunhaoling mentioned this pull request Oct 29, 2020
Merged
annatisch
annatisch reviewed Oct 29, 2020
View reviewed changes
annatisch
annatisch reviewed Oct 29, 2020
View reviewed changes
@yunhaoling yunhaoling requested a review from annatisch October 29, 2020 23:52
@yunhaoling
Copy link
Contributor Author

yunhaoling commented Nov 2, 2020

/azp run python - servicebus - tests

@azure-pipelines
Copy link

azure-pipelines bot commented Nov 2, 2020

Azure Pipelines successfully started running 1 pipeline(s).

@yunhaoling yunhaoling merged commit 2e5d263 into Azure:master Nov 2, 2020
@yunhaoling yunhaoling deleted the yuling-sb-settlement-move branch November 24, 2020 21:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@rakshith91 rakshith91 Awaiting requested review from rakshith91

@annatisch annatisch Awaiting requested review from annatisch

1 more reviewer

@KieranBrantnerMagee KieranBrantnerMagee KieranBrantnerMagee approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Service Bus

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@yunhaoling @annatisch @KieranBrantnerMagee