Skip to content

Automatic PR from RestAPI-PR1702#1454

Merged
lmazuel merged 1 commit intoAzure:masterfrom
AutorestCI:RestAPI-PR1702
Sep 20, 2017
Merged

Automatic PR from RestAPI-PR1702#1454
lmazuel merged 1 commit intoAzure:masterfrom
AutorestCI:RestAPI-PR1702

Conversation

@AutorestCI
Copy link
Copy Markdown
Contributor

Generated from RestAPI PR: Azure/azure-rest-api-specs#1702

@codecov-io
Copy link
Copy Markdown

codecov-io commented Sep 20, 2017

Codecov Report

Merging #1454 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master    #1454   +/-   ##
=======================================
  Coverage   54.62%   54.62%           
=======================================
  Files        3142     3142           
  Lines       79379    79379           
=======================================
  Hits        43362    43362           
  Misses      36017    36017
Impacted Files Coverage Δ
...work/v2017_09_01/models/virtual_network_peering.py 28.57% <ø> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update f95d529...86968a9. Read the comment docs.

@lmazuel
Copy link
Copy Markdown
Member

lmazuel commented Sep 20, 2017

Doc only

@lmazuel lmazuel merged commit d4e7dbd into Azure:master Sep 20, 2017
azure-sdk pushed a commit that referenced this pull request Mar 31, 2021
azure-sdk added a commit that referenced this pull request Apr 1, 2021
* Use SubscriptionId throughout TestResources

Fixes #1454

* Resolve PR feedback

* Default DeleteAfterHours to 48 for SDK team

Also makes a few other adjustments for subscriptions, like restoring the previous one if available and another was specified.

* Resolve PR feedback

* Change deployment mode to Complete

Also fixes an issue where if the user opted not to deploy to the same resource group, the script would continue execution anyway.

* Use consistent aka links to satisfy link checker

Only need it for the new Update-TestResources.ps1 script, but I wanted them to look consistent.

Co-authored-by: Heath Stewart <heaths@microsoft.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants