Skip to content

Only check the touched markdown files in PR for the Verify link step #14466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sima-zhu merged 5 commits into from
Oct 16, 2020
Merged

Only check the touched markdown files in PR for the Verify link step #14466

Changes from 1 commit
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
19ddd7c
Only check the touched markdown files in PR for the Verify link step
sima-zhu Oct 13, 2020
f3a2c45
Change to base branch insteasd of master
sima-zhu Oct 14, 2020
6b84419
add pr condition
sima-zhu Oct 15, 2020
a49ad17
Update archetype-sdk-client.yml
sima-zhu Oct 15, 2020
2f06041
remove the read me
sima-zhu Oct 16, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion eng/pipelines/templates/jobs/archetype-sdk-client.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -77,7 +77,8 @@ jobs:
steps:
- template: ../../../common/pipelines/templates/steps/verify-links.yml
parameters:
Directory: "sdk/${{ parameters.ServiceDirectory }}"
Directory: ''
Urls: (git diff origin/master HEAD --name-only -- *.md)
Copy link
Contributor

@mitchdenny mitchdenny Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems to be a strange value to be input into a parameter called Urls.

Copy link
Member

@weshaggard weshaggard Oct 14, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Urls can also point to local file paths :)

CheckLinkGuidance: $true

- template: ../steps/analyze.yml
Expand Down