Skip to content

Conversation

@shawncx
Copy link
Contributor

@shawncx shawncx commented Aug 18, 2020

@shawncx shawncx requested a review from zikalino as a code owner August 18, 2020 01:54
@mitchdenny
Copy link
Contributor

/azp run python - appplatform -ci

@azure-pipelines
Copy link

No pipelines are associated with this pull request.

@mitchdenny
Copy link
Contributor

/azp run python - appplatform - ci

@azure-pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@yuwzho
Copy link

yuwzho commented Aug 24, 2020

This change adds multi-version entries for appplatform, the folders sdk\appplatform\azure-mgmt-appplatform\azure\mgmt\appplatform\models and sdk\appplatform\azure-mgmt-appplatform\azure\mgmt\appplatform\operations should be removed.

@@ -1,5 +1,9 @@
# Release History

## 1.0.0 (2019-10-25)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wrong changelog?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed. Thanks

LATEST_PROFILE = ProfileDefinition({
_PROFILE_TAG: {
None: DEFAULT_API_VERSION,
'sku': '2019-05-01-preview',
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The 2020-07-01 also contains sku, why there is such an entry?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For 2019-05-01-preview, the resource name is sku, but for 2020-07, the resource name is skus. Because default api is 2020-07 which does not has sku, so it is listed here

Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for explaining

@shawncx shawncx merged commit 52bdd94 into Azure:release/v3 Aug 25, 2020
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Feb 26, 2021
Enable swagger ci for azure-powershell for some RPs (Azure#13166)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Feb 26, 2021
Enable swagger ci for azure-powershell for some RPs (Azure#13166)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Feb 26, 2021
Enable swagger ci for azure-powershell for some RPs (Azure#13166)
00Kai0 pushed a commit that referenced this pull request Mar 5, 2021
* CodeGen from PR 13166 in Azure/azure-rest-api-specs
Enable swagger ci for azure-powershell for some RPs (#13166)

* test,version,CHANGELOG

Co-authored-by: SDKAuto <[email protected]>
Co-authored-by: Yan Zhang (WICRESOFT NORTH AMERICA LTD) <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants