Skip to content

fix doc, sample, docstring #12784

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
xiangyan99 merged 3 commits into from
Jul 30, 2020
Merged

fix doc, sample, docstring #12784

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
c32a8bf
fix doc, sample, docstring
xiangyan99 Jul 29, 2020
6e72e6b
update version
xiangyan99 Jul 29, 2020
cfb7aa0
update
xiangyan99 Jul 30, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions sdk/appconfiguration/azure-appconfiguration/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,12 @@

-------------------

## 1.0.1 (Unreleased)

### Features
Comment thread
lmazuel marked this conversation as resolved.
Outdated

- Doc & Sample fixes

## 1.0.0 (2020-01-06)

### Features
Expand Down
4 changes: 2 additions & 2 deletions sdk/appconfiguration/azure-appconfiguration/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -201,7 +201,7 @@ deleted_config_setting = client.delete_configuration_setting(
```python

filtered_listed = client.list_configuration_settings(
labels=["*Labe*"], keys=["*Ke*"]
label_filter="My*", key_filter="My*"
)
for item in filtered_listed:
pass # do something
Expand Down Expand Up @@ -234,7 +234,7 @@ To use list_configuration_settings, call it synchronously and iterate over the r
```python

filtered_listed = async_client.list_configuration_settings(
labels=["*Labe*"], keys=["*Ke*"]
label_filter="My*", key_filter="My*"
)
async for item in filtered_listed:
pass # do something
Expand Down
4 changes: 2 additions & 2 deletions ...iguration/azure-appconfiguration/azure/appconfiguration/_azure_appconfiguration_client.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -183,7 +183,7 @@ def list_configuration_settings(
pass # do something

filtered_listed = client.list_configuration_settings(
label_filter="*Labe*", key_filter="*Ke*", accept_datetime=accept_datetime
label_filter="Labe*", key_filter="Ke*", accept_datetime=accept_datetime
)
for item in filtered_listed:
pass # do something
Expand Down Expand Up @@ -473,7 +473,7 @@ def list_revisions(
pass # do something

filtered_revisions = client.list_revisions(
label_filter="*Labe*", key_filter="*Ke*", accept_datetime=accept_datetime
label_filter="Labe*", key_filter="Ke*", accept_datetime=accept_datetime
)
for item in filtered_revisions:
pass # do something
Expand Down
2 changes: 1 addition & 1 deletion sdk/appconfiguration/azure-appconfiguration/azure/appconfiguration/_version.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,4 +3,4 @@
# Licensed under the MIT License.
# ------------------------------------

VERSION = "1.0.0"
VERSION = "1.0.1"
4 changes: 2 additions & 2 deletions ...on/azure-appconfiguration/azure/appconfiguration/aio/_azure_configuration_client_async.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -194,7 +194,7 @@ def list_configuration_settings(
pass # do something

filtered_listed = async_client.list_configuration_settings(
label_filter="*Labe*", key_filter="*Ke*", accept_datetime=accept_datetime
label_filter="Labe*", key_filter="Ke*", accept_datetime=accept_datetime
)
async for item in filtered_listed:
pass # do something
Expand Down Expand Up @@ -491,7 +491,7 @@ def list_revisions(
pass # do something

filtered_revisions = async_client.list_revisions(
label_filter="*Labe*", key_filter="*Ke*", accept_datetime=accept_datetime
label_filter="Labe*", key_filter="Ke*", accept_datetime=accept_datetime
)
async for item in filtered_revisions:
pass # do something
Expand Down
2 changes: 1 addition & 1 deletion sdk/appconfiguration/azure-appconfiguration/samples/hello_world_advanced_async_sample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,7 +45,7 @@ async def main():
print("")

print("List configuration settings")
config_settings = client.list_configuration_settings(labels=["MyLabel"])
config_settings = client.list_configuration_settings(label_filter="MyLabel")
async for item in config_settings:
print_configuration_setting(item)

Expand Down
2 changes: 1 addition & 1 deletion sdk/appconfiguration/azure-appconfiguration/samples/hello_world_advanced_sample.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -43,7 +43,7 @@ def main():
print("")

print("List configuration settings")
config_settings = client.list_configuration_settings(labels=["MyLabel"])
config_settings = client.list_configuration_settings(label_filter="MyLabel")
for item in config_settings:
print_configuration_setting(item)

Expand Down