Skip to content

[Cosmos] Fix type comment #12598

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
annatisch merged 2 commits into from
Jul 20, 2020
Merged

[Cosmos] Fix type comment #12598

annatisch merged 2 commits into from
Jul 20, 2020

Conversation

@adeolemon
Copy link
Contributor

@adeolemon adeolemon commented Jul 17, 2020 •
edited
Loading

Fixes #12570

@ghost ghost added the Cosmos label Jul 17, 2020
@adeolemon adeolemon changed the title [Cosmos] Change type comment [Cosmos] Fix type comment Jul 17, 2020
@adeolemon
Copy link
Contributor Author

adeolemon commented Jul 20, 2020

PyCharm seems happy with the proposed solution:

image

@annatisch
Copy link
Member

annatisch commented Jul 20, 2020

Thanks @notlaforge! Even though it's tiny - could we please add a line to the changelog that has a reference to the issue number?

@adeolemon
Copy link
Contributor Author

adeolemon commented Jul 20, 2020

Oh yeah ofc

@annatisch annatisch merged commit fefb924 into Azure:master Jul 20, 2020
@adeolemon adeolemon deleted the type-comment-fix branch July 20, 2020 22:45
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request Jul 21, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
e9cbd87 
…into ta_opinion_mining_sample

* 'master' of https://github.com/Azure/azure-sdk-for-python: (124 commits)
  [formrecognizer] Add type to FormField (Azure#12561)
  Add example summary for azure-identity readme.md (Azure#12509)
  Add logging to credentials (Azure#12319)
  Sdk automation/track2 azure mgmt keyvault (Azure#12638)
  Remove unnecessary coroutine declaration (Azure#12602)
  [Cosmos] Fix type comment (Azure#12598)
  replace aka link (Azure#12597)
  [ServiceBus] Message/ReceivedMessage Properties alignment with other languages (Azure#12451)
  Find list of installed packages using pkg_resources (Azure#12591)
  token refresh offset (Azure#12136)
  updates (Azure#12595)
  User authentication samples (Azure#11343)
  Remove unnecessary base class (Azure#12374)
  Sequence -> Iterable for scopes (Azure#12579)
  Disable apistubgen step until issue is fixed (Azure#12594)
  fix pylint issue (Azure#12578)
  fix name in example (Azure#12572)
  Update tests.md (Azure#12574)
  Add stress tests for max batch size/prefetch, and for unsettled message receipt.  Add capability to not auto-complete and adjust max_batch_size into the base stress tester. (Azure#12344)
  [formrecognizer] Capitalize enum values (Azure#12540)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@annatisch annatisch annatisch approved these changes

@zfoster zfoster Awaiting requested review from zfoster

+1 more reviewer

@southpolesteve southpolesteve southpolesteve approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

Cosmos

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Inaccurate type comment in functions for azure-cosmos package

3 participants

@adeolemon @annatisch @southpolesteve