Skip to content

[ServiceBus] Message/ReceivedMessage Properties alignment with other languages #12451

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
yunhaoling merged 17 commits into from
Jul 18, 2020
Merged

[ServiceBus] Message/ReceivedMessage Properties alignment with other languages #12451

Show file tree
Hide file tree
Changes from 11 commits
Commits
Show all changes
17 commits
Select commit Hold shift + click to select a range
5d8f36c
additional properties
yunhaoling Jul 8, 2020
3efdc55
add properties and reorder them
yunhaoling Jul 9, 2020
5203876
add comment and internalize variables
yunhaoling Jul 14, 2020
9265792
update changelog and fix mypy pylint
yunhaoling Jul 14, 2020
91ea250
fix pylint
yunhaoling Jul 14, 2020
40d81b7
fix pylint
yunhaoling Jul 14, 2020
6cc8adf
update impl, sample, livetest and doc
yunhaoling Jul 15, 2020
29772e0
Merge remote-tracking branch 'central/master' into sb-message-properties
yunhaoling Jul 15, 2020
1cce42a
fix pylint
yunhaoling Jul 15, 2020
9c9e4d3
remove partition_id
yunhaoling Jul 15, 2020
666ae27
fix merge problem
yunhaoling Jul 15, 2020
0882f13
update according to comment
yunhaoling Jul 16, 2020
b3677b2
fixed bug in previous implementation when setting annotation multiple…
yunhaoling Jul 16, 2020
5161d7f
fix pylint
yunhaoling Jul 16, 2020
6759eb1
fix py2.7 unittest
yunhaoling Jul 16, 2020
888fc93
add settled back first
yunhaoling Jul 17, 2020
39c0af2
add session_id and reply_to_session_id assertion
yunhaoling Jul 17, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
23 changes: 23 additions & 0 deletions sdk/servicebus/azure-servicebus/CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,29 @@

## 7.0.0b5 (Unreleased)

**New Features**

* Added new properties to Message, PeekMessage and ReceivedMessage: `content_type`, `correlation_id`, `label`,
`message_id`, `reply_to`, `reply_to_session_id` and `to`. Please refer to the docstring for further information.

* Add new properties to PeekedMessaged and ReceivedMessage: `enqueued_sequence_number`, `dead_letter_error_description`,
`dead_letter_reason`, `dead_letter_source`, `delivery_count` and `expires_at_utc`. Please refer to the docstring for further information.

**Breaking Changes**

* Removed/Renamed several properties and instance variables on Message (the changes applied to the inherited Message type PeekMessage and ReceivedMessage).
- Renamed property `user_properties` to `properties`
- The original instance variable `properties` which represents the AMQP properties now becomes an internal instance variable `_amqp_properties`.
- Removed property `enqueue_sequence_number`.
- Removed property `annotations`.
- Removed instance variable `header`.

* Removed several properties and instance variables on PeekMessage and ReceivedMessage.
- Removed proeprty `partition_id` on both type.
- Removed property `settled` on both type.
Comment thread
KieranBrantnerMagee marked this conversation as resolved.
Outdated
- Removed instance variable `received_timestamp_utc` on both type.
- Removed property `expired` on `ReceivedMessage`.


## 7.0.0b4 (2020-07-06)

Expand Down
5 changes: 4 additions & 1 deletion sdk/servicebus/azure-servicebus/azure/servicebus/_common/constants.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,7 +3,6 @@
# Licensed under the MIT License. See License.txt in the project root for
# license information.
# -------------------------------------------------------------------------

from enum import Enum

from uamqp import constants
Expand Down Expand Up @@ -97,6 +96,10 @@
_X_OPT_LOCKED_UNTIL = b'x-opt-locked-until'
_X_OPT_LOCK_TOKEN = b'x-opt-lock-token'
_X_OPT_SCHEDULED_ENQUEUE_TIME = b'x-opt-scheduled-enqueue-time'
_X_OPT_DEAD_LETTER_SOURCE = b'x-opt-deadletter-source'

PROPERTIES_DEAD_LETTER_REASON = b'DeadLetterReason'
PROPERTIES_DEAD_LETTER_ERROR_DESCRIPTION = b'DeadLetterErrorDescription'


DEAD_LETTER_QUEUE_SUFFIX = '/$DeadLetterQueue'
Expand Down
Loading