Skip to content

Conversation

@chidozieononiwu
Copy link
Member

@weshaggard
Copy link
Member

eng/common changes merged into repo with #12386.

@scbedd scbedd merged commit b39c411 into Azure:master Jul 7, 2020
@scbedd
Copy link
Member

scbedd commented Jul 8, 2020

Hey @chidozieononiwu ,

My bad for missing this again. I'm disabling this step. The check is definitely doing something insane. We're releasing 12.4.0b1 of azure-storage-blob, and it's rejecting because 12.4.0-b1 is what it's looking for. I need to unblock releases. Will see what I can do to fix it regardless.

I think we should block on re-enabling this until we see a successful release with it.

scbedd added a commit to scbedd/azure-sdk-for-python that referenced this pull request Jul 8, 2020
xiafu-msft pushed a commit that referenced this pull request Jul 8, 2020
@chidozieononiwu
Copy link
Member Author

Hey @chidozieononiwu ,

My bad for missing this again. I'm disabling this step. The check is definitely doing something insane. We're releasing 12.4.0b1 of azure-storage-blob, and it's rejecting because 12.4.0-b1 is what it's looking for. I need to unblock releases. Will see what I can do to fix it regardless.

I think we should block on re-enabling this until we see a successful release with it.

Hey @scbedd sorry again about this. This bug is from the pkgpprops tool which makes use of the AzureEngSemanticVersion class. Unfortunately that class is dotnet biased as shown in the ToString() method which formats the version to dotnet style. I opened an issue to address this but its probably best to wait till we settle on a standard way of naming preview version across languages. For now I have added changes to the pkgprops tool to bypass the need to call the ToString method of the AzureEngSemanticVersion class.

openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Feb 4, 2021
[NetAppFiles] Anf 9085 update swagger rest api to 2020 11 01 (Azure#12388)
openapi-sdkautomation bot pushed a commit to AzureSDKAutomation/azure-sdk-for-python that referenced this pull request Feb 4, 2021
[NetAppFiles] Anf 9085 update swagger rest api to 2020 11 01 (Azure#12388)
00Kai0 added a commit that referenced this pull request Feb 7, 2021
* CodeGen from PR 12388 in Azure/azure-rest-api-specs
[NetAppFiles] Anf 9085 update swagger rest api to 2020 11 01 (#12388)

* test,version,CHANGELOG

* fix changelog and version

Co-authored-by: SDKAuto <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants