-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Re-Enable changelog verification #12388
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Re-Enable changelog verification #12388
Conversation
|
eng/common changes merged into repo with #12386. |
|
Hey @chidozieononiwu , My bad for missing this again. I'm disabling this step. The check is definitely doing something insane. We're releasing I think we should block on re-enabling this until we see a successful release with it. |
This reverts commit b39c411.
Hey @scbedd sorry again about this. This bug is from the pkgpprops tool which makes use of the AzureEngSemanticVersion class. Unfortunately that class is dotnet biased as shown in the ToString() method which formats the version to dotnet style. I opened an issue to address this but its probably best to wait till we settle on a standard way of naming preview version across languages. For now I have added changes to the pkgprops tool to bypass the need to call the ToString method of the AzureEngSemanticVersion class. |
[NetAppFiles] Anf 9085 update swagger rest api to 2020 11 01 (Azure#12388)
[NetAppFiles] Anf 9085 update swagger rest api to 2020 11 01 (Azure#12388)
* CodeGen from PR 12388 in Azure/azure-rest-api-specs [NetAppFiles] Anf 9085 update swagger rest api to 2020 11 01 (#12388) * test,version,CHANGELOG * fix changelog and version Co-authored-by: SDKAuto <[email protected]>
Add back changes removed in https://github.com/Azure/azure-sdk-for-python/pull/12359/files since changelog logic has been updated Azure/azure-sdk-tools#755