Update Key Vault minimum azure-core to 1.4.0 #12074
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chlowell
added
KeyVault
Client
iscai-msft
previously approved these changes
Jun 16, 2020
Contributor
iscai-msft
left a comment
iscai-msft
left a comment
There was a problem hiding this comment.
Feel free to ignore comment. Looks good, thanks!
|
|
||
| ## 4.2.0b2 (Unreleased) | ||
|
|
||
| - Updated minimum `azure-core` version to 1.4.0 |
Contributor
There was a problem hiding this comment.
nit: include reason for bumping azure-core version
iscai-msft
approved these changes
Jun 17, 2020
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jun 17, 2020
…into regenerate_keys * 'master' of https://github.com/Azure/azure-sdk-for-python: (26 commits) [formrecognizer] update formrecognizer links to new aka.ms naming (Azure#12079) changes in samples tests (Azure#12090) readme & sample updates (Azure#12095) Update Key Vault minimum azure-core to 1.4.0 (Azure#12074) [formrecognizer] test parity with other languages (Azure#12059) syncing missing changelog items (Azure#12089) updating doc references (Azure#12086) reserve 1 more version for storage and network (Azure#12082) Fix format in swagger_to_sdk_config.json (Azure#12083) modify changelog (Azure#12071) Update Cosmos CODEOWNERS (Azure#11500) Regenerate LUIS (Azure#12064) Enable track2 SDK Automation config on master branch (Azure#11654) Update KeyVaultPreparer with track 2 mgmt changes (Azure#12060) Increment version for storage releases (Azure#12034) AzureCliCredential correctly invokes /bin/sh (Azure#12056) [formrecognizer] reduce time for recorded tests runs (Azure#11970) disable some bandit warnings (Azure#12054) Respect nbf and exp in local encrypt/wrap operations (Azure#11953) add bug_bash template (Azure#12045) ...
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jun 17, 2020
…into regenerate_certs * 'master' of https://github.com/Azure/azure-sdk-for-python: (21 commits) [formrecognizer] update formrecognizer links to new aka.ms naming (Azure#12079) changes in samples tests (Azure#12090) readme & sample updates (Azure#12095) Update Key Vault minimum azure-core to 1.4.0 (Azure#12074) [formrecognizer] test parity with other languages (Azure#12059) syncing missing changelog items (Azure#12089) updating doc references (Azure#12086) reserve 1 more version for storage and network (Azure#12082) Fix format in swagger_to_sdk_config.json (Azure#12083) modify changelog (Azure#12071) Update Cosmos CODEOWNERS (Azure#11500) Regenerate LUIS (Azure#12064) Enable track2 SDK Automation config on master branch (Azure#11654) Update KeyVaultPreparer with track 2 mgmt changes (Azure#12060) Increment version for storage releases (Azure#12034) AzureCliCredential correctly invokes /bin/sh (Azure#12056) [formrecognizer] reduce time for recorded tests runs (Azure#11970) disable some bandit warnings (Azure#12054) Respect nbf and exp in local encrypt/wrap operations (Azure#11953) add bug_bash template (Azure#12045) ...
iscai-msft
added a commit
to iscai-msft/azure-sdk-for-python
that referenced
this pull request
Jun 22, 2020
…into regenerate_secrets * 'master' of https://github.com/Azure/azure-sdk-for-python: (39 commits) [text analytics] remove duplicate platform info in user agent (Azure#12123) [form recognizer] remove duplicate platform info in user agent (Azure#12124) fix broken links (Azure#12100) Document "<unchanged>" for DataSourceCredentials.connectionString if it is empty (Azure#12129) Let the transport handles bad urls (Azure#12106) Remove Unneeded Reference to repository resource (Azure#11929) enable logging for tests (Azure#12110) fix network in batch testcase (Azure#12114) update test recording for appservice (Azure#12116) Add test for connection monitor and fix test api version. (Azure#12113) Minor root readme and mgmt quickstart update for Track 2 mgmt sdk (Azure#12112) Quickstart for Track 2 preview management libraries and update root readme for track 2 (Azure#11384) Seg fault fix (Azure#11933) [formrecognizer] update formrecognizer links to new aka.ms naming (Azure#12079) changes in samples tests (Azure#12090) readme & sample updates (Azure#12095) Update Key Vault minimum azure-core to 1.4.0 (Azure#12074) [formrecognizer] test parity with other languages (Azure#12059) syncing missing changelog items (Azure#12089) updating doc references (Azure#12086) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The minimum version of
azure-coreaccepted by Key Vault libraries is lower than that of the prereleaseazure-mgmt-keyvault. This is a problem in the mindependency test because that test installs the lower version, which lacks featuresazure-mgmt-keyvaultneeds. I expect the next version ofazure-keyvault-*to require some of those same features, so this PR pre-emptively raises those libraries' minimumazure-coreversion to solve the mindependency problem.