begin_recognize_receipts APIs now return RecognizedForm
#11894
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rakshith91
changed the title
begin_recognize_receipts and begin_recognize_receipts_from_url now return RecognizedForm and begin_recognize_receipts APIs now return RecognizedReceipt.
rakshith91
changed the title
begin_recognize_receipts and begin_recognize_receipts_from_url now return RecognizedForm and begin_recognize_receipts APIs now return RecognizedReceipt.begin_recognize_receipts and begin_recognize_receipts_from_url now return RecognizedForm
rakshith91
changed the title
begin_recognize_receipts and begin_recognize_receipts_from_url now return RecognizedFormbegin_recognize_receipts APIs now return RecognizedForm
iscai-msft
reviewed
Jun 9, 2020
Contributor
There was a problem hiding this comment.
Everything looks good, you just forgot to remove mention of RecognizedReceipt from the readme: https://github.com/Azure/azure-sdk-for-python/tree/master/sdk/formrecognizer/azure-ai-formrecognizer#formrecognizerclient
iscai-msft
reviewed
Jun 9, 2020
Contributor
There was a problem hiding this comment.
I'd still include this sentence, just say that it returns a collection of RecognizedForm
Contributor
|
LGTM, I'll approve after we release |
kristapratico
previously approved these changes
Jun 10, 2020
Contributor
kristapratico
left a comment
kristapratico
left a comment
There was a problem hiding this comment.
Rebasing on master should fix the analyze step error in CI
rakshith91
force-pushed
the
recognize_receipt
branch
from
8eac67c to
91870e7
Compare
kristapratico
approved these changes
Jun 11, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #11880