Skip to content

Add user authentication API to UsernamePasswordCredential #11528

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
chlowell merged 4 commits into from
May 20, 2020
Merged

Add user authentication API to UsernamePasswordCredential #11528

chlowell merged 4 commits into from
May 20, 2020

Conversation

@chlowell
Copy link
Member

@chlowell chlowell commented May 19, 2020

Closes #11449

@chlowell chlowell added Client This issue points to a problem in the data-plane of the library. Azure.Identity labels May 19, 2020
@chlowell chlowell requested a review from xiangyan99 May 19, 2020 19:50
@chlowell chlowell requested a review from schaabs as a code owner May 19, 2020 19:50
@chlowell chlowell force-pushed the user-pass-authrecord branch from 18264c9 to deb4f74 Compare May 19, 2020 19:52
xiangyan99
xiangyan99 reviewed May 19, 2020
View reviewed changes
sdk/identity/azure-identity/azure/identity/_credentials/user_password.py
# first time it's asked for a token. However, we want to ensure this first authentication is not silent, to
# validate the given password. This class therefore doesn't document the authentication_record argument, and we
# discard it here.
kwargs.pop("authentication_record", None)
Copy link
Member

@xiangyan99 xiangyan99 May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In old code, I see

for account in accounts:
result = app.acquire_token_silent(scopes, account=account)
if result:
break

It seems to me we allow first time silent authentication?

Copy link
Member Author

@chlowell chlowell May 19, 2020

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may appear so but that was actually impossible because the cache was in memory; the credential always started with an empty one.

@chlowell chlowell merged commit f5bc51a into Azure:master May 20, 2020
@chlowell chlowell deleted the user-pass-authrecord branch May 20, 2020 17:51
@jiasli jiasli mentioned this pull request May 21, 2020
Merged
iscai-msft added a commit to iscai-msft/azure-sdk-for-python that referenced this pull request May 21, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
71866ae 
…into make_canary_test

* 'master' of https://github.com/Azure/azure-sdk-for-python: (28 commits)
  Kaihuis maps (Azure#11574)
  [formrecognizer] support Copy API (Azure#11372)
  Artifact Powered Docs.MS Release (Azure#11395)
  Sync eng/common directory with azure-sdk-tools repository (Azure#11562)
  Updated changelog (Azure#11554)
  update pinned versions in autorest_req.txt (Azure#11557)
  Add user authentication API to UsernamePasswordCredential (Azure#11528)
  Reduce Build Matrix (Azure#11539)
  Prevent Key Vault test failure due to operation timing (Azure#11552)
  update tests (Azure#11534)
  Datashare 2019 11 01 (Azure#11540)
  Search Renames / Regen (Azure#11342)
  update unit test according to the latest uamqp update (Azure#11533)
  Sync eng/common directory with azure-sdk-tools repository (Azure#11472)
  rename input parameters (Azure#11518)
  [cosmos] readme review feedback (Azure#11527)
  Update CODEOWNERS (Azure#11516)
  [Core] Support multipart changesets (Azure#10972)
  fix AttributeException (Azure#11463)
  release-for-hanaonazure-mgmt (Azure#11441)
  ...
iscai-msft added a commit that referenced this pull request May 21, 2020
@iscai-msft
Merge branch 'master' of https://github.com/Azure/azure-sdk-for-python …
a38f5ef 
…into feature/text_analytics_v3.0

* 'master' of https://github.com/Azure/azure-sdk-for-python: (28 commits)
  Kaihuis maps (#11574)
  [formrecognizer] support Copy API (#11372)
  Artifact Powered Docs.MS Release (#11395)
  Sync eng/common directory with azure-sdk-tools repository (#11562)
  Updated changelog (#11554)
  update pinned versions in autorest_req.txt (#11557)
  Add user authentication API to UsernamePasswordCredential (#11528)
  Reduce Build Matrix (#11539)
  Prevent Key Vault test failure due to operation timing (#11552)
  update tests (#11534)
  Datashare 2019 11 01 (#11540)
  Search Renames / Regen (#11342)
  update unit test according to the latest uamqp update (#11533)
  Sync eng/common directory with azure-sdk-tools repository (#11472)
  rename input parameters (#11518)
  [cosmos] readme review feedback (#11527)
  Update CODEOWNERS (#11516)
  [Core] Support multipart changesets (#10972)
  fix AttributeException (#11463)
  release-for-hanaonazure-mgmt (#11441)
  ...
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@xiangyan99 xiangyan99 xiangyan99 approved these changes

@schaabs schaabs Awaiting requested review from schaabs

Assignees

No one assigned

Labels

Azure.Identity Client This issue points to a problem in the data-plane of the library.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

Add new user auth API to UsernamePasswordCredential

2 participants

@chlowell @xiangyan99