Add Search Service stats API #10371
Merged
Add Search Service stats API #10371
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
bryevdv
commented
Mar 19, 2020
sdk/search/azure-search-documents/azure/search/documents/_service/_search_service_client.py
Outdated
Show resolved
Hide resolved
johanste
reviewed
Mar 19, 2020
...earch/azure-search-documents/azure/search/documents/_index/aio/_search_index_client_async.py
Show resolved
Hide resolved
johanste
reviewed
Mar 19, 2020
sdk/search/azure-search-documents/azure/search/documents/_service/_search_service_client.py
Show resolved
Hide resolved
johanste
reviewed
Mar 19, 2020
| """ | ||
|
|
||
| def __init__(self, endpoint, credential, **kwargs): | ||
| # type: (str, SearchApiKeyCredential, **Any) -> None |
Member
There was a problem hiding this comment.
@brjohnstmsft, are there any plans to support token credentials for search?
Member
There was a problem hiding this comment.
@johanste I'm pretty sure the answer is yes, since we're looking at adding AAD authentication to the service this year.
johanste
reviewed
Mar 19, 2020
sdk/search/azure-search-documents/azure/search/documents/_service/_search_service_client.py
Show resolved
Hide resolved
johanste
approved these changes
Mar 19, 2020
Member
johanste
left a comment
johanste
left a comment
There was a problem hiding this comment.
Feel free to open an issue on the sdk_moniker comment. Or just fix it :).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #9666