[Service Bus]"Preparer failure when creating resource ServiceBusNamespacePreparer, Resource group could not be found" on UsGov and China cloud

[v-xuto]

We are running live Tests against other clouds like US Gov and Azure China Cloud. The goal is to check whether new azure sdk package work with other clouds or not.

Error Description:
When running the test tests\test_queues.py::ServiceBusQueueTests::test_github_issue_6178 on UsGov and China cloud, it runs failed and the error message is shown as following, for more details please check here:

Error Track:
The code that failed is here：

code link2:

Note: We guessed that the environment variable did not set the value of RESOURCE_REGION, so the default value ‘westus’ was used, so the resource group was not created successfully in UsGov and China Cloud.

Expected Behavior:
The resource group was successfully created and it can be found.

@benbp , @jameszliao-msft , @lmazuel , @lilyjma , @ramya-rao-a and @annatisch for notification.

[benbp]

If you change RESOURCE_REGION to SERVICEBUS_LOCATION it should be able to look up the value correctly based on the context set by the resource deployment scripts.

[v-xuto]

@benbp

1. First, because get_region_override is a method in tools devtools_testutils, so we update location=get_region_override('westus') to location=os.environ.get("SERVICEBUS_LOCATION", None) or 'westus' in class ServiceBusNamespacePreparer(AzureMgmtPreparer). But it still reports the same error, its location is still westus. We suspect that this parameter SERVICEBUS_LOCATION has no value or is 'westus' ?
2. Then, we update location=get_region_override('westus') to location='usgovarizona', it reports the following error, for more details in here:

(test_queues.ServiceBusQueueTests): (LocationNotAvailableForResourceType) The provided location '***' is not available for resource type 'Microsoft.ServiceBus/namespaces'. List of available regions for the resource type is 'australiaeast,australiasoutheast,centralus,eastus,eastus2,westus2,westus,northcentralus,southcentralus,westcentralus,eastasia,southeastasia,brazilsouth,japaneast,japanwest,northeurope,westeurope,centralindia,southindia,westindia,canadacentral,canadaeast,ukwest,uksouth,koreacentral,koreasouth,francecentral,southafricanorth,uaenorth,australiacentral,switzerlandnorth,germanywestcentral,norwayeast,jioindiawest,westus3,centraluseuap,eastus2euap'.

By reporting the error message, we suspect that it is still under the public cloud. This is confusing, where is it going to the corresponding cloud environment.

Do you have any ideas?

[benbp]

@v-xuto sorry this is my mistake! Looks like it's called SERVICE_BUS_LOCATION. You can see the key names of the env outputs that get set in the Deploy test resources logs:

https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1080695&view=logs&j=eb4e8fab-410d-5462-8da4-6074733a2525&t=5877313e-8ad1-5e16-7cf7-7ae7932c113c&l=3267

[v-xuto]

@benbp We updated SERVICEBUS_LOCATION to SERVICE_BUS_LOCATION, there is still the same error, its location is still westus, for more details please check here. Besides, we update location=get_region_override('westus') to location='usgovarizona', by reporting the error message, we suspect that it is still under the public cloud.

[benbp]

@v-xuto I didn't see that it was in the dev tools location. You might try instead setting RESOURCE_REGION as an output value in the test-resources.json corresponding to [resourceGroup().location].

Looking at your branch, you also need to update the azure environment values to reference the dynamic cloud subscription config variables instead of the hardcoded public cloud variable group. That's why it's looking in public:

https://github.com/Azure/azure-sdk-for-python/blob/a0ae039fe05f3b5bfb0ff48f4355836c5f234f22/sdk/servicebus/tests.yml#L14-L17
https://dev.azure.com/azure-sdk/internal/_build/results?buildId=1093075&view=logs&j=eb4e8fab-410d-5462-8da4-6074733a2525&t=5877313e-8ad1-5e16-7cf7-7ae7932c113c&l=3300

        AZURE_SUBSCRIPTION_ID: $(SERVICEBUS_SUBSCRIPTION_ID)
        AZURE_TENANT_ID: $(SERVICEBUS_TENANT_ID)
        AZURE_CLIENT_ID: $(SERVICEBUS_CLIENT_ID)
        AZURE_CLIENT_SECRET: $(SERVICEBUS_CLIENT_SECRET)

[v-xuto]

@benbp - I have updated the code by your comments. But we encountered the following error, for more details please check here:
Usgov:
azure_devtools.scenario_tests.preparers:preparers.py:82 Preparer failure when creating resource ServiceBusNamespacePreparer for test test_github_issue_6178 (test_queues.ServiceBusQueueTests): , AdalError: Get Token request returned http error: 400 and server response: {"error":"invalid_request","error_description":"AADSTS900382: Confidential Client is not supported in Cross Cloud request.}

China:
azure_devtools.scenario_tests.preparers:preparers.py:82 Preparer failure when creating resource ***erviceBusNamespacePreparer for test test_github_issue_6178 (test_queues.***erviceBusQueueTests): , AdalError: Get Token request returned http error: 400 and server response: {"error":"invalid_request","error_description":"AAD***T***90002: Tenant '***' not found. Check to make sure you have the correct tenant ID and are signing into the correct cloud. Check with your subscription administrator, this may happen if there are no active subscriptions for the tenant.}

Do you have any ideas?

[benbp]

@v-xuto it seems like the tenant id is still not getting set for the sovereign cloud properly, which is generally the issue for errors like not supported in Cross Cloud request. @scbedd I tried to dig a little through the devtools to see whether a custom tenant id isn't getting passed through properly, but I couldn't find anything that indicated a problem. Perhaps you have an idea?