-
Notifications
You must be signed in to change notification settings - Fork 3.2k
Closed
Description
Action items:
- Reconsider the main scenario for translation and whether it should instead return a poller. If the P90 <= 2 docs and time from submission to completion <15 sec then an LRO makes sense. Understand from service team why the service is optimized for queueing many jobs/documents since this does not fit the common use case stated. Note that if we make this change, some of the below items are obsolete. Issue: [translation] consider poller design #17915
- rename
DocumentStatusResult.translate_to-->translated_to -
Improve documentation forcreate_translation_job. This should include info about how it starts the job but thatwait_until_donemust be used to complete the job -
Rename variables in samples that sayjob_result. This result suffix made people think the job was already finished - Fix the ItemPaged references in docs so that they show that it's an
ItemPaged[DocumentStatusResult]etc - Check that we have a link in the README that links to the service docs about how to create the SAS URLs
- Reconsider the model names
TranslationStatusResultandDocumentStatusResult. People saw "status" in the name and assumed that a string was returned, not an object. Tracked in [translation] renames #19257 - Overload the input to
create_translation_jobto be more friendly in the single document scenario. Effectively option 1 in this issue: [translation] consider simplifying input to translation #17916 - Reconsider the naming of
inputstobegin_translation. Perhaps this should beactionsto align with TA and then the input object,DocumentTranslationInputshould be called something likeDocumentTranslationAction. -
Reconsider the utility ofhas_completed. People thought that this attribute would get updated when accessed, when reality it's just doing a completion check on the status strings