[keyvault] Invalid comparison in azure.keyvault.keys.crypto._internal.jose

[zooba]

azure-sdk-for-python/sdk/keyvault/azure-keyvault-keys/azure/keyvault/keys/crypto/_internal/jose.py

Lines 97 to 98 in 8c819a4

	if not (self.protected, self.encrypted_key, self.iv, self.ciphertext, self.tag):
	raise ValueError("JWE is not complete.")

In the above code, the if not (tuple-with-any-elements): check will always evaluate to True.

I believe in this case you want if not all((self.protected, ...)) to ensure that each specified element is not empty.

[kaerm]

Thanks @zooba, @chlowell can you take a look at this

[chlowell]

Looks like a bug to me, thanks @zooba. However, we don't (and may never) use this code. This crypto._internal code began as a prototype largely ported from C#, added wholesale when I needed an adapter between Key Vault and cryptography. I think the best way to resolve this issue is to delete the unused code. I'll assign this issue to myself and leave it on the backlog for now.