Skip to content
This repository was archived by the owner on May 5, 2023. It is now read-only.

Conversation

@qiaozha
Copy link
Member

@qiaozha qiaozha commented Nov 11, 2021

This is the PR to show the change of ms-rest-azure 2.6.1

@qiaozha
Copy link
Member Author

qiaozha commented Nov 11, 2021

@ramya-rao-a Here's the change for 2.6.1, I create this branch from the current main branch, so there'll be no change on the adal-node version bump. https://github.com/Azure/azure-sdk-for-node/pull/5216/files#diff-abbfd30520c59e62631b34bba16b50f929bc41e0e675d7575cbf82d53f96a3aaL28

@ramya-rao-a
Copy link
Contributor

@qiaozha What I meant in #5213 was that we should have a branch that reflects the state of things for ms-rest-azure 2.6.1. This will help us make future hotfixes.

  • Create a branch ms-rest-azure-v2 from master from the point where version 2.6.0 of ms-rest-azure was released
  • Make the changes required to update adal-node
  • In the future use this branch to make v2 hotfixes for ms-rest-azure

@qiaozha
Copy link
Member Author

qiaozha commented Nov 16, 2021

@ramya-rao-a I get your point, but my concern is that there's a lot of other changes after 3.0.0 commit and I am worried if we revert those changes and leave the branch there, it may cause other potential issues. I think the branch in this PR can correctly reflect what's the code look like in 2.6.1 for ms-rest-azure and at the same time doesn't revert those changes for other packages. Let me know if that makes sense to you.

@ramya-rao-a
Copy link
Contributor

Understood, that works for me

Thanks @qiaozha

We can close this PR

@qiaozha qiaozha closed this Nov 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants